Skip to content

Fix regression in assigning BicepValue<T> to properties #53934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 26, 2025
Merged

Fix regression in assigning BicepValue<T> to properties #53934

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d926515
change everything to be package reference
ArcturusZhang Nov 14, 2025
c6d579e
fix the first issue of copying values
ArcturusZhang Nov 14, 2025
4cc9260
fix the issue and add more test cases
ArcturusZhang Nov 14, 2025
220b65b
some refinements
ArcturusZhang Nov 14, 2025
6ac892a
add some more test cases
ArcturusZhang Nov 14, 2025
41017ce
update
ArcturusZhang Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...zure.Provisioning.AppConfiguration/tests/Azure.Provisioning.AppConfiguration.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\core\Azure.Core.TestFramework\src\Azure.Core.TestFramework.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning\src\Azure.Provisioning.csproj" />
<ProjectReference Include="..\src\Azure.Provisioning.AppConfiguration.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning.Deployment\src\Azure.Provisioning.Deployment.csproj" />
</ItemGroup>
</Project>
</Project>
3 changes: 2 additions & 1 deletion ...ning/Azure.Provisioning.AppContainers/tests/Azure.Provisioning.AppContainers.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\core\Azure.Core.TestFramework\src\Azure.Core.TestFramework.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning\src\Azure.Provisioning.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning.OperationalInsights\src\Azure.Provisioning.OperationalInsights.csproj" />
<ProjectReference Include="..\src\Azure.Provisioning.AppContainers.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning.Deployment\src\Azure.Provisioning.Deployment.csproj" />
</ItemGroup>
</Project>
</Project>
3 changes: 2 additions & 1 deletion ...ovisioning/Azure.Provisioning.AppService/tests/Azure.Provisioning.AppService.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,10 @@
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\core\Azure.Core.TestFramework\src\Azure.Core.TestFramework.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning\src\Azure.Provisioning.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning.ApplicationInsights\src\Azure.Provisioning.ApplicationInsights.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning.Storage\src\Azure.Provisioning.Storage.csproj" />
<ProjectReference Include="..\src\Azure.Provisioning.AppService.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning.Deployment\src\Azure.Provisioning.Deployment.csproj" />
</ItemGroup>
</Project>
</Project>
3 changes: 2 additions & 1 deletion ...rovisioning.ApplicationInsights/tests/Azure.Provisioning.ApplicationInsights.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\core\Azure.Core.TestFramework\src\Azure.Core.TestFramework.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning\src\Azure.Provisioning.csproj" />
<ProjectReference Include="..\src\Azure.Provisioning.ApplicationInsights.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning.Deployment\src\Azure.Provisioning.Deployment.csproj" />
</ItemGroup>
</Project>
</Project>
3 changes: 2 additions & 1 deletion ...re.Provisioning.CognitiveServices/tests/Azure.Provisioning.CognitiveServices.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\core\Azure.Core.TestFramework\src\Azure.Core.TestFramework.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning\src\Azure.Provisioning.csproj" />
<ProjectReference Include="..\src\Azure.Provisioning.CognitiveServices.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning.Deployment\src\Azure.Provisioning.Deployment.csproj" />
</ItemGroup>
</Project>
</Project>
3 changes: 2 additions & 1 deletion ...ning/Azure.Provisioning.Communication/tests/Azure.Provisioning.Communication.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\core\Azure.Core.TestFramework\src\Azure.Core.TestFramework.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning\src\Azure.Provisioning.csproj" />
<ProjectReference Include="..\src\Azure.Provisioning.Communication.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning.Deployment\src\Azure.Provisioning.Deployment.csproj" />
</ItemGroup>
</Project>
</Project>
1 change: 1 addition & 0 deletions ...re.Provisioning.ContainerRegistry/tests/Azure.Provisioning.ContainerRegistry.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\core\Azure.Core.TestFramework\src\Azure.Core.TestFramework.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning\src\Azure.Provisioning.csproj" />
<ProjectReference Include="..\src\Azure.Provisioning.ContainerRegistry.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning.Deployment\src\Azure.Provisioning.Deployment.csproj" />
</ItemGroup>
Expand Down
3 changes: 2 additions & 1 deletion sdk/provisioning/Azure.Provisioning.ContainerRegistry/tests/BasicContainerRegistryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Licensed under the MIT License.

using System.Threading.Tasks;
using Azure.Provisioning.Expressions;
using Azure.Provisioning.Tests;
using NUnit.Framework;

Expand All @@ -20,6 +21,7 @@ internal static Trycep CreateContainerRegistryTest()
ContainerRegistryService registry =
new(nameof(registry), ContainerRegistryService.ResourceVersions.V2023_07_01)
{
Name = BicepFunction.Take(BicepFunction.Interpolate($"registry{BicepFunction.GetUniqueString(BicepFunction.GetResourceGroup().Id)}"), 50),
Sku = new ContainerRegistrySku { Name = ContainerRegistrySkuName.Standard },
IsAdminUserEnabled = false,
Tags = { { "displayName", "ContainerRegistry" } }
Expand All @@ -36,7 +38,6 @@ internal static Trycep CreateContainerRegistryTest()

[Test]
[Description("https://github.com/Azure/azure-quickstart-templates/blob/master/quickstarts/microsoft.containerregistry/container-registry/main.bicep")]
[Ignore("https://github.com/Azure/azure-sdk-for-net/issues/53862")]
public async Task CreateContainerRegistry()
{
await using Trycep test = CreateContainerRegistryTest();
Expand Down
3 changes: 2 additions & 1 deletion ...zure.Provisioning.ContainerService/tests/Azure.Provisioning.ContainerService.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\core\Azure.Core.TestFramework\src\Azure.Core.TestFramework.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning\src\Azure.Provisioning.csproj" />
<ProjectReference Include="..\src\Azure.Provisioning.ContainerService.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning.Deployment\src\Azure.Provisioning.Deployment.csproj" />
</ItemGroup>
</Project>
</Project>
3 changes: 2 additions & 1 deletion sdk/provisioning/Azure.Provisioning.CosmosDB/tests/Azure.Provisioning.CosmosDB.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\core\Azure.Core.TestFramework\src\Azure.Core.TestFramework.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning\src\Azure.Provisioning.csproj" />
<ProjectReference Include="..\src\Azure.Provisioning.CosmosDB.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning.Deployment\src\Azure.Provisioning.Deployment.csproj" />
</ItemGroup>
</Project>
</Project>
1 change: 1 addition & 0 deletions ...ovisioning/Azure.Provisioning.Deployment/tests/Azure.Provisioning.Deployment.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

<ItemGroup>
<ProjectReference Include="..\..\..\core\Azure.Core.TestFramework\src\Azure.Core.TestFramework.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning\src\Azure.Provisioning.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning.Storage\src\Azure.Provisioning.Storage.csproj" />
<ProjectReference Include="..\src\Azure.Provisioning.Deployment.csproj" />
</ItemGroup>
Expand Down
3 changes: 2 additions & 1 deletion sdk/provisioning/Azure.Provisioning.Dns/tests/Azure.Provisioning.Dns.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\core\Azure.Core.TestFramework\src\Azure.Core.TestFramework.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning\src\Azure.Provisioning.csproj" />
<ProjectReference Include="..\src\Azure.Provisioning.Dns.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning.Deployment\src\Azure.Provisioning.Deployment.csproj" />
</ItemGroup>
</Project>
</Project>
3 changes: 2 additions & 1 deletion ...provisioning/Azure.Provisioning.EventGrid/tests/Azure.Provisioning.EventGrid.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\core\Azure.Core.TestFramework\src\Azure.Core.TestFramework.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning\src\Azure.Provisioning.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning.Storage\src\Azure.Provisioning.Storage.csproj" />
<ProjectReference Include="..\src\Azure.Provisioning.EventGrid.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning.Deployment\src\Azure.Provisioning.Deployment.csproj" />
</ItemGroup>
</Project>
</Project>
3 changes: 2 additions & 1 deletion ...provisioning/Azure.Provisioning.EventHubs/tests/Azure.Provisioning.EventHubs.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\core\Azure.Core.TestFramework\src\Azure.Core.TestFramework.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning\src\Azure.Provisioning.csproj" />
<ProjectReference Include="..\src\Azure.Provisioning.EventHubs.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning.Deployment\src\Azure.Provisioning.Deployment.csproj" />
</ItemGroup>
</Project>
</Project>
1 change: 1 addition & 0 deletions ...provisioning/Azure.Provisioning.FrontDoor/tests/Azure.Provisioning.FrontDoor.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\core\Azure.Core.TestFramework\src\Azure.Core.TestFramework.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning\src\Azure.Provisioning.csproj" />
<ProjectReference Include="..\src\Azure.Provisioning.FrontDoor.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning.Deployment\src\Azure.Provisioning.Deployment.csproj" />
</ItemGroup>
Expand Down
3 changes: 2 additions & 1 deletion sdk/provisioning/Azure.Provisioning.KeyVault/tests/Azure.Provisioning.KeyVault.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\core\Azure.Core.TestFramework\src\Azure.Core.TestFramework.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning\src\Azure.Provisioning.csproj" />
<ProjectReference Include="..\src\Azure.Provisioning.KeyVault.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning.Deployment\src\Azure.Provisioning.Deployment.csproj" />
</ItemGroup>
</Project>
</Project>
3 changes: 2 additions & 1 deletion ...ovisioning/Azure.Provisioning.Kubernetes/tests/Azure.Provisioning.Kubernetes.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\core\Azure.Core.TestFramework\src\Azure.Core.TestFramework.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning\src\Azure.Provisioning.csproj" />
<ProjectReference Include="..\src\Azure.Provisioning.Kubernetes.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning.Deployment\src\Azure.Provisioning.Deployment.csproj" />
</ItemGroup>
</Project>
</Project>
3 changes: 2 additions & 1 deletion ...ing.KubernetesConfiguration/tests/Azure.Provisioning.KubernetesConfiguration.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\core\Azure.Core.TestFramework\src\Azure.Core.TestFramework.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning\src\Azure.Provisioning.csproj" />
<ProjectReference Include="..\src\Azure.Provisioning.KubernetesConfiguration.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning.Deployment\src\Azure.Provisioning.Deployment.csproj" />
</ItemGroup>
</Project>
</Project>
1 change: 1 addition & 0 deletions sdk/provisioning/Azure.Provisioning.Kusto/tests/Azure.Provisioning.Kusto.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\core\Azure.Core.TestFramework\src\Azure.Core.TestFramework.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning\src\Azure.Provisioning.csproj" />
<ProjectReference Include="..\src\Azure.Provisioning.Kusto.csproj" />
<PackageReference Include="Azure.Provisioning.CosmosDB" />
<PackageReference Include="Azure.Provisioning.EventGrid" />
Expand Down
3 changes: 2 additions & 1 deletion sdk/provisioning/Azure.Provisioning.Network/tests/Azure.Provisioning.Network.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\core\Azure.Core.TestFramework\src\Azure.Core.TestFramework.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning\src\Azure.Provisioning.csproj" />
<ProjectReference Include="..\src\Azure.Provisioning.Network.csproj" />
<PackageReference Include="Azure.Provisioning.Storage" />
<ProjectReference Include="..\..\Azure.Provisioning.Deployment\src\Azure.Provisioning.Deployment.csproj" />
</ItemGroup>
</Project>
</Project>
3 changes: 2 additions & 1 deletion ...rovisioning.OperationalInsights/tests/Azure.Provisioning.OperationalInsights.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\core\Azure.Core.TestFramework\src\Azure.Core.TestFramework.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning\src\Azure.Provisioning.csproj" />
<ProjectReference Include="..\src\Azure.Provisioning.OperationalInsights.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning.Deployment\src\Azure.Provisioning.Deployment.csproj" />
</ItemGroup>
</Project>
</Project>
3 changes: 2 additions & 1 deletion ...ovisioning/Azure.Provisioning.PostgreSql/tests/Azure.Provisioning.PostgreSql.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\core\Azure.Core.TestFramework\src\Azure.Core.TestFramework.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning\src\Azure.Provisioning.csproj" />
<ProjectReference Include="..\src\Azure.Provisioning.PostgreSql.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning.Deployment\src\Azure.Provisioning.Deployment.csproj" />
</ItemGroup>
</Project>
</Project>
3 changes: 2 additions & 1 deletion sdk/provisioning/Azure.Provisioning.Redis/tests/Azure.Provisioning.Redis.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\core\Azure.Core.TestFramework\src\Azure.Core.TestFramework.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning\src\Azure.Provisioning.csproj" />
<ProjectReference Include="..\src\Azure.Provisioning.Redis.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning.Deployment\src\Azure.Provisioning.Deployment.csproj" />
</ItemGroup>
</Project>
</Project>
1 change: 1 addition & 0 deletions .../Azure.Provisioning.RedisEnterprise/tests/Azure.Provisioning.RedisEnterprise.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\core\Azure.Core.TestFramework\src\Azure.Core.TestFramework.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning\src\Azure.Provisioning.csproj" />
<ProjectReference Include="..\src\Azure.Provisioning.RedisEnterprise.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning.Deployment\src\Azure.Provisioning.Deployment.csproj" />
</ItemGroup>
Expand Down
3 changes: 2 additions & 1 deletion sdk/provisioning/Azure.Provisioning.Search/tests/Azure.Provisioning.Search.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\core\Azure.Core.TestFramework\src\Azure.Core.TestFramework.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning\src\Azure.Provisioning.csproj" />
<ProjectReference Include="..\src\Azure.Provisioning.Search.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning.Deployment\src\Azure.Provisioning.Deployment.csproj" />
</ItemGroup>
</Project>
</Project>
3 changes: 2 additions & 1 deletion ...ovisioning/Azure.Provisioning.ServiceBus/tests/Azure.Provisioning.ServiceBus.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\core\Azure.Core.TestFramework\src\Azure.Core.TestFramework.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning\src\Azure.Provisioning.csproj" />
<ProjectReference Include="..\src\Azure.Provisioning.ServiceBus.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning.Deployment\src\Azure.Provisioning.Deployment.csproj" />
</ItemGroup>
</Project>
</Project>
3 changes: 2 additions & 1 deletion sdk/provisioning/Azure.Provisioning.SignalR/tests/Azure.Provisioning.SignalR.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\core\Azure.Core.TestFramework\src\Azure.Core.TestFramework.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning\src\Azure.Provisioning.csproj" />
<ProjectReference Include="..\src\Azure.Provisioning.SignalR.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning.Deployment\src\Azure.Provisioning.Deployment.csproj" />
</ItemGroup>
</Project>
</Project>
3 changes: 2 additions & 1 deletion sdk/provisioning/Azure.Provisioning.Sql/tests/Azure.Provisioning.Sql.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\core\Azure.Core.TestFramework\src\Azure.Core.TestFramework.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning\src\Azure.Provisioning.csproj" />
<ProjectReference Include="..\src\Azure.Provisioning.Sql.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning.Deployment\src\Azure.Provisioning.Deployment.csproj" />
</ItemGroup>
</Project>
</Project>
1 change: 1 addition & 0 deletions sdk/provisioning/Azure.Provisioning.Storage/tests/Azure.Provisioning.Storage.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\core\Azure.Core.TestFramework\src\Azure.Core.TestFramework.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning\src\Azure.Provisioning.csproj" />
<ProjectReference Include="..\src\Azure.Provisioning.Storage.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning.Deployment\src\Azure.Provisioning.Deployment.csproj" />
</ItemGroup>
Expand Down
3 changes: 2 additions & 1 deletion ...provisioning/Azure.Provisioning.WebPubSub/tests/Azure.Provisioning.WebPubSub.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\core\Azure.Core.TestFramework\src\Azure.Core.TestFramework.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning\src\Azure.Provisioning.csproj" />
<ProjectReference Include="..\src\Azure.Provisioning.WebPubSub.csproj" />
<ProjectReference Include="..\..\Azure.Provisioning.Deployment\src\Azure.Provisioning.Deployment.csproj" />
</ItemGroup>
</Project>
</Project>
2 changes: 2 additions & 0 deletions sdk/provisioning/Azure.Provisioning/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

### Bugs Fixed

- Fixed bug when assigning property to a collection throwing exceptions. ([#53862](https://github.com/Azure/azure-sdk-for-net/issues/53862))

### Other Changes

## 1.4.0-beta.2 (2025-11-10)
Expand Down
27 changes: 21 additions & 6 deletions sdk/provisioning/Azure.Provisioning/src/BicepDictionaryOfT.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,15 @@ internal BicepDictionary(BicepValueReference? self, IDictionary<string, BicepVal
{
// in this case, the list is initialized as a literal list
_kind = BicepValueKind.Literal;
_values = new Dictionary<string, BicepValue<T>>(values); // Shallow clone their values
_values = new Dictionary<string, BicepValue<T>>(values.Count);
// assign values from input into our own dictionary
foreach (var pair in values)
{
var value = new BicepValue<T>((BicepValueReference?)null);
SetSelfForItem(value, pair.Key);
value.Assign(pair.Value);
_values.Add(pair.Key, value);
}
}
}

Expand Down Expand Up @@ -128,9 +136,14 @@ public BicepValue<T> this[string key]
{
_kind = BicepValueKind.Literal;
}
_values[key] = value;
// update the _self pointing the new item
SetSelfForItem(value, key);
if (_values.TryGetValue(key, out var result))
{
result.Assign(value);
}
else
{
Add(key, value);
}
}
}

Expand All @@ -144,9 +157,11 @@ public void Add(string key, BicepValue<T> value)
{
_kind = BicepValueKind.Literal;
}
_values.Add(key, value);
var addedItem = new BicepValue<T>((BicepValueReference?)null);
_values.Add(key, addedItem);
addedItem.Assign(value);
// update the _self pointing the new item
SetSelfForItem(value, key);
SetSelfForItem(addedItem, key);
}

public void Add(KeyValuePair<string, BicepValue<T>> item) => Add(item.Key, item.Value);
Expand Down
Loading
Loading