Fix DLQ reason and description not transmitted in ServiceBus binder

[sunghyun1999]

Summary

• Remove the redundant no-arg messageContext.deadLetter() call in ServiceBusMessageChannelBinder.deadLetter() that settles the message before the parameterized deadLetter(options) can set the DLQ reason and error description
• This is a one-line deletion fix — the no-arg call was left over from PR Fix DLQ reason and description not work #41172 which addressed the original issue [BUG] DLQ reason and description not work in spring-cloud-azure-stream-binder-servicebus #40951

Root Cause

// Before (bug): line 230 settles the message immediately without reason/description
messageContext.deadLetter();          // ← settles message, no reason
messageContext.deadLetter(options);   // ← ignored, message already settled

// After (fix): only the parameterized call remains
messageContext.deadLetter(options);   // ← settles with reason and description

Test Plan

• Verified the code change by reviewing the deadLetter method logic
• The fix aligns with the approach suggested by the issue reporter and confirmed by @dreyinger

Fixes #41883

🤖 Generated with Claude Code

[github-actions]

Thank you for your contribution @sunghyun1999! We will review the pull request and get back to you soon.

[Copilot]

Pull request overview

This PR fixes a bug in the Spring Cloud Azure Service Bus Stream Binder where the dead-letter reason and error description were not being transmitted, due to a redundant no-arg deadLetter() call settling the message before the parameterized deadLetter(options) call could apply the details.

Changes:

• Removed the redundant no-arg messageContext.deadLetter() call so the message is dead-lettered only via DeadLetterOptions.
• Ensured DLQ reason and description can be applied when dead-lettering received messages.

Comments suppressed due to low confidence (1)

sdk/spring/spring-cloud-azure-stream-binder-servicebus/src/main/java/com/azure/spring/cloud/stream/binder/servicebus/implementation/ServiceBusMessageChannelBinder.java:233

• The current test coverage doesn’t guard against regressions where messageContext.deadLetter() (no-arg) is called before messageContext.deadLetter(options). That exact sequencing caused the original bug (options ignored after settlement), but ServiceBusMessageChannelBinderTest.testDeadLetterCalledForError only verifies the parameterized overload was called (and would still pass if an extra no-arg deadLetter call happened). Consider strengthening the test to assert the no-arg overload is never invoked (e.g., verify(messageContext, never()).deadLetter(); and/or verifyNoMoreInteractions(messageContext) after the options verification).

        final ServiceBusReceivedMessageContext messageContext = (ServiceBusReceivedMessageContext) message
            .getHeaders()
            .get(ServiceBusMessageHeaders.RECEIVED_MESSAGE_CONTEXT);
        if (messageContext != null) {
            DeadLetterOptions options = new DeadLetterOptions();
            options.setDeadLetterReason(deadLetterReason);
            options.setDeadLetterErrorDescription(deadLetterErrorDescription);
            messageContext.deadLetter(options);

[rujche]

Closing in favor of #49663