Remove pip install termcolor from spring pipelines for network isolation#49464
Merged
rujche merged 1 commit intoJun 12, 2026
Merged
Conversation
termcolor is only used in sdk/spring/scripts/log.py, which already falls back gracefully via try/except ImportError when termcolor is absent. Removing the install avoids external PyPI access under the upcoming CI network isolation policy (PyPI access failure).
Member
Author
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes python -m pip install termcolor steps from Spring CI/pipeline YAMLs to avoid external PyPI access under upcoming CI network isolation, relying on the existing sdk/spring/scripts/log.py graceful fallback when termcolor is unavailable.
Changes:
- Removed
pip install termcolorfrom Spring monitor pipeline job templates. - Removed
pip install termcolorfrom Spring compatibility test pipeline job templates. - Kept Python logging behavior intact by relying on existing
try/except ImportErrorfallback insdk/spring/scripts/log.py(verified: only usage oftermcolorundersdk/spring).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/spring/spring-cloud-azure-starter-monitor/tests.yml | Removes the pre-generation pip install termcolor step for monitor matrix generation. |
| sdk/spring/pipeline/monitor-tests-job.yml | Removes pip install termcolor from the monitor tests job template. |
| sdk/spring/pipeline/compatibility-tests-job.yml | Removes conditional pip install termcolor from the compatibility tests job template. |
| sdk/spring/compatibility-tests.yml | Removes pre-generation pip install termcolor steps from compatibility test stage definitions. |
raych1
approved these changes
Jun 11, 2026
Netyyyy
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
termcolor is only used in sdk/spring/scripts/log.py, which already falls back gracefully via try/except ImportError when termcolor is absent. Removing the install avoids external PyPI access under the upcoming CI network isolation policy (PyPI access failure).
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines