Skip to content

Remove pip install termcolor from spring pipelines for network isolation#49464

Merged
rujche merged 1 commit into
mainfrom
rujche/main/delete-pip-install-to-fit-network-isolation
Jun 12, 2026
Merged

Remove pip install termcolor from spring pipelines for network isolation#49464
rujche merged 1 commit into
mainfrom
rujche/main/delete-pip-install-to-fit-network-isolation

Conversation

@rujche

@rujche rujche commented Jun 11, 2026

Copy link
Copy Markdown
Member

Description

termcolor is only used in sdk/spring/scripts/log.py, which already falls back gracefully via try/except ImportError when termcolor is absent. Removing the install avoids external PyPI access under the upcoming CI network isolation policy (PyPI access failure).

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

termcolor is only used in sdk/spring/scripts/log.py, which already falls
back gracefully via try/except ImportError when termcolor is absent.
Removing the install avoids external PyPI access under the upcoming CI
network isolation policy (PyPI access failure).
Copilot AI review requested due to automatic review settings June 11, 2026 09:12
@rujche rujche self-assigned this Jun 11, 2026
@rujche rujche added the azure-spring All azure-spring related issues label Jun 11, 2026
@rujche rujche added this to the 2026-07 milestone Jun 11, 2026
@rujche

rujche commented Jun 11, 2026

Copy link
Copy Markdown
Member Author

/azp run java - spring - tests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes python -m pip install termcolor steps from Spring CI/pipeline YAMLs to avoid external PyPI access under upcoming CI network isolation, relying on the existing sdk/spring/scripts/log.py graceful fallback when termcolor is unavailable.

Changes:

  • Removed pip install termcolor from Spring monitor pipeline job templates.
  • Removed pip install termcolor from Spring compatibility test pipeline job templates.
  • Kept Python logging behavior intact by relying on existing try/except ImportError fallback in sdk/spring/scripts/log.py (verified: only usage of termcolor under sdk/spring).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
sdk/spring/spring-cloud-azure-starter-monitor/tests.yml Removes the pre-generation pip install termcolor step for monitor matrix generation.
sdk/spring/pipeline/monitor-tests-job.yml Removes pip install termcolor from the monitor tests job template.
sdk/spring/pipeline/compatibility-tests-job.yml Removes conditional pip install termcolor from the compatibility tests job template.
sdk/spring/compatibility-tests.yml Removes pre-generation pip install termcolor steps from compatibility test stage definitions.

@rujche rujche moved this from Todo to In Progress in Spring Cloud Azure Jun 12, 2026
@rujche rujche merged commit b033d87 into main Jun 12, 2026
94 checks passed
@rujche rujche deleted the rujche/main/delete-pip-install-to-fit-network-isolation branch June 12, 2026 01:36
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Spring Cloud Azure Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure-spring All azure-spring related issues

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants