Skip to content

[Storage] Refine Create user delegation SAS logic#27517

Merged
dolauli merged 2 commits intoAzure:mainfrom
wastoresh:udsas
Apr 24, 2025
Merged

[Storage] Refine Create user delegation SAS logic#27517
dolauli merged 2 commits intoAzure:mainfrom
wastoresh:udsas

Conversation

@blueww
Copy link
Copy Markdown
Member

@blueww blueww commented Apr 7, 2025

Report error when user try to create User delegation sas with oauth Storage context which not include storage account name, since StorageAccountname is required in create user delegation sas API in SDK.

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 7, 2025

‼️ DO NOT MERGE THIS PR ‼️
This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.

@blueww
Copy link
Copy Markdown
Member Author

blueww commented Apr 7, 2025

I still need do more test with it.
Will remove the "Do Not merge" tag when test finished.

@dolauli dolauli self-assigned this Apr 24, 2025
@dolauli dolauli merged commit 55a61da into Azure:main Apr 24, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants