Skip to content

feat: settlement decorator changes #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 30, 2025
Merged

feat: settlement decorator changes #297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69be852
settlement decorator changes
hallvictoria Sep 11, 2025
b9ef15a
lint
hallvictoria Sep 11, 2025
ec049c4
Merge branch 'dev' into hallvictoria/message-settlement
hallvictoria Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions azure/functions/decorators/function_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,6 +673,7 @@ def service_bus_queue_trigger(
access_rights: Optional[Union[AccessRights, str]] = None,
is_sessions_enabled: Optional[bool] = None,
cardinality: Optional[Union[Cardinality, str]] = None,
auto_complete_messages: Optional[bool] = None,
**kwargs: Any) -> Callable[..., Any]:
"""
The `on_service_bus_queue_change` decorator adds :class:`ServiceBusQueueTrigger` to the
Expand All @@ -697,6 +698,8 @@ def service_bus_queue_trigger(
:param is_sessions_enabled: Set to True if connecting to a session-aware queue
or subscription.
:param cardinality: Set to "many" to enable batching.
:param auto_complete_messages: Indicates whether the message should be automatically
completed.

:return: Decorator function.
"""
Expand All @@ -717,6 +720,7 @@ def decorator():
is_sessions_enabled=is_sessions_enabled,
cardinality=parse_singular_param_to_enum(cardinality,
Cardinality),
auto_complete_messages=auto_complete_messages,
**kwargs))
return fb

Expand All @@ -734,6 +738,7 @@ def service_bus_topic_trigger(
access_rights: Optional[Union[AccessRights, str]] = None,
is_sessions_enabled: Optional[bool] = None,
cardinality: Optional[Union[Cardinality, str]] = None,
auto_complete_messages: Optional[bool] = None,
**kwargs: Any) -> Callable[..., Any]:
"""
The `on_service_bus_topic_change` decorator adds :class:`ServiceBusTopicTrigger` to the
Expand All @@ -759,6 +764,8 @@ def service_bus_topic_trigger(
:param is_sessions_enabled: Set to True if connecting to a session-aware queue
or subscription.
:param cardinality: Set to "many" to enable batching.
:param auto_complete_messages: Indicates whether the message should be automatically
completed.

:return: Decorator function.
"""
Expand All @@ -780,6 +787,7 @@ def decorator():
is_sessions_enabled=is_sessions_enabled,
cardinality=parse_singular_param_to_enum(cardinality,
Cardinality),
auto_complete_messages=auto_complete_messages,
**kwargs))
return fb

Expand Down
52 changes: 52 additions & 0 deletions tests/decorators/test_servicebus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,31 @@ def test_service_bus_queue_trigger_valid_creation(self):
"cardinality": Cardinality.ONE
})

def test_service_bus_queue_trigger_autocomplete_valid_creation(self):
trigger = ServiceBusQueueTrigger(name="req", connection="dummy_conn",
queue_name="dummy_queue",
data_type=DataType.UNDEFINED,
access_rights=AccessRights.MANAGE,
is_sessions_enabled=True,
cardinality=Cardinality.ONE,
auto_complete_messages=True,
dummy_field="dummy")

self.assertEqual(trigger.get_binding_name(), "serviceBusTrigger")
self.assertEqual(trigger.get_dict_repr(), {
"type": SERVICE_BUS_TRIGGER,
"direction": BindingDirection.IN,
'dummyField': 'dummy',
"name": "req",
"connection": "dummy_conn",
"queueName": "dummy_queue",
"dataType": DataType.UNDEFINED,
"accessRights": AccessRights.MANAGE,
"isSessionsEnabled": True,
"cardinality": Cardinality.ONE,
"autoCompleteMessages": True
})

def test_service_bus_queue_output_valid_creation(self):
service_bus_queue_output = ServiceBusQueueOutput(
name="res",
Expand Down Expand Up @@ -82,6 +107,33 @@ def test_service_bus_topic_trigger_valid_creation(self):
"cardinality": Cardinality.ONE
})

def test_service_bus_topic_trigger_autocomplete_valid_creation(self):
trigger = ServiceBusTopicTrigger(name="req", connection="dummy_conn",
topic_name="dummy_topic",
subscription_name="dummy_sub",
data_type=DataType.UNDEFINED,
access_rights=AccessRights.MANAGE,
is_sessions_enabled=True,
cardinality=Cardinality.ONE,
auto_complete_messages=True,
dummy_field="dummy")

self.assertEqual(trigger.get_binding_name(), "serviceBusTrigger")
self.assertEqual(trigger.get_dict_repr(), {
"type": SERVICE_BUS_TRIGGER,
"direction": BindingDirection.IN,
'dummyField': 'dummy',
"name": "req",
"connection": "dummy_conn",
"topicName": "dummy_topic",
"subscriptionName": "dummy_sub",
"dataType": DataType.UNDEFINED,
"accessRights": AccessRights.MANAGE,
"isSessionsEnabled": True,
"cardinality": Cardinality.ONE,
"autoCompleteMessages": True
})

def test_service_bus_topic_output_valid_creation(self):
output = ServiceBusTopicOutput(name="res", connection="dummy_conn",
topic_name="dummy_topic",
Expand Down