Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not return a StripPrefix handler when building checker #3559

Merged
merged 2 commits into from
Apr 4, 2025
Merged

fix: do not return a StripPrefix handler when building checker #3559

merged 2 commits into from
Apr 4, 2025

Conversation

tyler-lloyd
Copy link
Contributor

Reason for Change:

already doing the strip prefix https://github.com/tyler-lloyd/azure-container-networking/blob/40b6c443d62321ee61c134bf6573ed2de9813d50/cns/healthserver/server.go#L15

so doing it inside check builder is redunant and causes the /healthz endpoint to return a 404

Issue Fixed:

Requirements:

Notes:

@Copilot Copilot bot review requested due to automatic review settings April 3, 2025 22:53
@tyler-lloyd tyler-lloyd requested a review from a team as a code owner April 3, 2025 22:53
@tyler-lloyd tyler-lloyd requested a review from thatmattlong April 3, 2025 22:53
Copilot
Copilot AI reviewed Apr 3, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@rbtr
Copy link
Contributor

rbtr commented Apr 3, 2025

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nddq nddq added this pull request to the merge queue Apr 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 4, 2025
@paulyufan2 paulyufan2 added this pull request to the merge queue Apr 4, 2025
Merged via the queue into Azure:master with commit 7c218a5 Apr 4, 2025
14 checks passed
@tyler-lloyd tyler-lloyd deleted the fix-strip-prefix branch April 4, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@rbtr rbtr rbtr approved these changes

@nddq nddq nddq approved these changes

@paulyufan2 paulyufan2 paulyufan2 approved these changes

@thatmattlong thatmattlong Awaiting requested review from thatmattlong thatmattlong is a code owner automatically assigned from Azure/acn-cns-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tyler-lloyd @rbtr @nddq @paulyufan2