ci: add code coverage publishing and check to pipeline #3544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the CI pipeline by adding code coverage publishing and regression checks to ensure that new changes do not significantly decrease overall test coverage.
- Adds "set -e" to enforce early failure on errors during testing
- Creates symlinks for gocov and gocov-xml and generates coverage reports
- Publishes the coverage report and adds a coverage regression check step
Files not reviewed (1)
- Makefile: Language not supported
Comments suppressed due to low confidence (1)
.pipelines/templates/run-unit-tests.yaml:23
- The line with '{ { { {' appears to be stray text that may have been accidentally committed. Consider removing it to ensure the script executes as intended.
{ { { {
QxBytes
force-pushed
the
alew/ut-coverage
branch
from
187e25c to
3f6bedd
Compare
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the CI pipeline by adding steps to publish and check code coverage, ensuring that any significant regressions in code coverage are flagged. Key changes include:
- Adding a "set -e" command to catch script failures.
- Adding new steps for generating and publishing the coverage report.
- Introducing a build quality check task for verifying code coverage regressions.
Files not reviewed (1)
- Makefile: Language not supported
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rbtr
approved these changes
Apr 3, 2025
jpayne3506
approved these changes
Apr 3, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
The current pr pipeline does not check if a PR drastically decreases the code coverage of the repository, nor does it publish code coverage results to the code coverage tab in ADO. This PR enables publishing code coverage and should mark the build as a failure if the code coverage decreases by a significant amount (> 0.25% I believe) compared to the master branch. Merges code coverage between windows and linux oses.
Issue Fixed:
See above
Requirements:
Notes: