Skip to content

Conversation

@mihretkidane-OCI
Copy link

@mihretkidane-OCI mihretkidane-OCI commented Nov 18, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings November 18, 2025 17:10
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Nov 18, 2025

❌Azure CLI Extensions Breaking Change Test
❌oracle-database
rule cmd_name rule_message suggest_message
1007 - ParaRemove oracle-database autonomous-database create cmd oracle-database autonomous-database create removed parameter scheduled_operations please add back parameter scheduled_operations for cmd oracle-database autonomous-database create
1007 - ParaRemove oracle-database autonomous-database update cmd oracle-database autonomous-database update removed parameter scheduled_operations please add back parameter scheduled_operations for cmd oracle-database autonomous-database update
⚠️ 1001 - CmdAdd oracle-database autonomous-database action cmd oracle-database autonomous-database action added
⚠️ 1001 - CmdAdd oracle-database autonomous-database change-disaster-recovery-configuration cmd oracle-database autonomous-database change-disaster-recovery-configuration added
⚠️ 1001 - CmdAdd oracle-database autonomous-database character-set show cmd oracle-database autonomous-database character-set show added
⚠️ 1006 - ParaAdd oracle-database autonomous-database create cmd oracle-database autonomous-database create added parameter clone_from_backup_timestamp
⚠️ 1006 - ParaAdd oracle-database autonomous-database create cmd oracle-database autonomous-database create added parameter cross_region_disaster_recovery
⚠️ 1006 - ParaAdd oracle-database autonomous-database create cmd oracle-database autonomous-database create added parameter scheduled_operations_list
⚠️ 1010 - ParaPropUpdate oracle-database autonomous-database create cmd oracle-database autonomous-database create update parameter admin_password: updated property aaz_type from AAZPasswordArg to string
⚠️ 1010 - ParaPropUpdate oracle-database autonomous-database create cmd oracle-database autonomous-database create update parameter admin_password: updated property type from Password to string
⚠️ 1006 - ParaAdd oracle-database autonomous-database failover cmd oracle-database autonomous-database failover added parameter peer_db_location
⚠️ 1006 - ParaAdd oracle-database autonomous-database failover cmd oracle-database autonomous-database failover added parameter peer_db_ocid
⚠️ 1001 - CmdAdd oracle-database autonomous-database generate-wallet cmd oracle-database autonomous-database generate-wallet added
⚠️ 1001 - CmdAdd oracle-database autonomous-database national-character-set show cmd oracle-database autonomous-database national-character-set show added
⚠️ 1001 - CmdAdd oracle-database autonomous-database shrink cmd oracle-database autonomous-database shrink added
⚠️ 1006 - ParaAdd oracle-database autonomous-database switchover cmd oracle-database autonomous-database switchover added parameter peer_db_location
⚠️ 1006 - ParaAdd oracle-database autonomous-database switchover cmd oracle-database autonomous-database switchover added parameter peer_db_ocid
⚠️ 1006 - ParaAdd oracle-database autonomous-database update cmd oracle-database autonomous-database update added parameter clone_from_backup_timestamp
⚠️ 1006 - ParaAdd oracle-database autonomous-database update cmd oracle-database autonomous-database update added parameter cross_region_disaster_recovery
⚠️ 1006 - ParaAdd oracle-database autonomous-database update cmd oracle-database autonomous-database update added parameter scheduled_operations_list
⚠️ 1010 - ParaPropUpdate oracle-database autonomous-database update cmd oracle-database autonomous-database update update parameter admin_password: updated property aaz_type from AAZPasswordArg to string
⚠️ 1010 - ParaPropUpdate oracle-database autonomous-database update cmd oracle-database autonomous-database update update parameter admin_password: updated property type from Password to string
⚠️ 1001 - CmdAdd oracle-database autonomous-database version show cmd oracle-database autonomous-database version show added
⚠️ 1001 - CmdAdd oracle-database cloud-exadata-infrastructure add-storage-capacity cmd oracle-database cloud-exadata-infrastructure add-storage-capacity added
⚠️ 1001 - CmdAdd oracle-database cloud-exadata-infrastructure configure-exascale cmd oracle-database cloud-exadata-infrastructure configure-exascale added
⚠️ 1006 - ParaAdd oracle-database cloud-exadata-infrastructure create cmd oracle-database cloud-exadata-infrastructure create added parameter database_server_type
⚠️ 1006 - ParaAdd oracle-database cloud-exadata-infrastructure create cmd oracle-database cloud-exadata-infrastructure create added parameter storage_server_type
⚠️ 1001 - CmdAdd oracle-database cloud-exadata-infrastructure database-server show cmd oracle-database cloud-exadata-infrastructure database-server show added
⚠️ 1006 - ParaAdd oracle-database cloud-vm-cluster create cmd oracle-database cloud-vm-cluster create added parameter exascale_db_storage_vault_id
⚠️ 1001 - CmdAdd oracle-database cloud-vm-cluster database-node show cmd oracle-database cloud-vm-cluster database-node show added
⚠️ 1001 - CmdAdd oracle-database cloud-vm-cluster list-private-ip-address cmd oracle-database cloud-vm-cluster list-private-ip-address added
⚠️ 1006 - ParaAdd oracle-database cloud-vm-cluster update cmd oracle-database cloud-vm-cluster update added parameter file_system_configuration_details
⚠️ 1011 - SubgroupAdd oracle-database cloud-vm-cluster virtual-network-address sub group oracle-database cloud-vm-cluster virtual-network-address added
⚠️ 1006 - ParaAdd oracle-database database-system-shape list cmd oracle-database database-system-shape list added parameter shape_attribute
⚠️ 1006 - ParaAdd oracle-database database-system-shape list cmd oracle-database database-system-shape list added parameter zone
⚠️ 1001 - CmdAdd oracle-database database-system-shape show cmd oracle-database database-system-shape show added
⚠️ 1011 - SubgroupAdd oracle-database db-system sub group oracle-database db-system added
⚠️ 1011 - SubgroupAdd oracle-database db-system-db-version sub group oracle-database db-system-db-version added
⚠️ 1001 - CmdAdd oracle-database dns-private-view show cmd oracle-database dns-private-view show added
⚠️ 1001 - CmdAdd oracle-database dns-private-zone show cmd oracle-database dns-private-zone show added
⚠️ 1011 - SubgroupAdd oracle-database exadb-vm-cluster sub group oracle-database exadb-vm-cluster added
⚠️ 1011 - SubgroupAdd oracle-database exascale-db-storage-vault sub group oracle-database exascale-db-storage-vault added
⚠️ 1011 - SubgroupAdd oracle-database flex-component sub group oracle-database flex-component added
⚠️ 1011 - SubgroupAdd oracle-database gi-minor-version sub group oracle-database gi-minor-version added
⚠️ 1006 - ParaAdd oracle-database gi-version list cmd oracle-database gi-version list added parameter shape_attribute
⚠️ 1006 - ParaAdd oracle-database gi-version list cmd oracle-database gi-version list added parameter shape
⚠️ 1006 - ParaAdd oracle-database gi-version list cmd oracle-database gi-version list added parameter zone
⚠️ 1001 - CmdAdd oracle-database gi-version show cmd oracle-database gi-version show added
⚠️ 1011 - SubgroupAdd oracle-database network-anchor sub group oracle-database network-anchor added
⚠️ 1011 - SubgroupAdd oracle-database oracle-subscription sub group oracle-database oracle-subscription added
⚠️ 1011 - SubgroupAdd oracle-database resource-anchor sub group oracle-database resource-anchor added
⚠️ 1011 - SubgroupAdd oracle-database system-version sub group oracle-database system-version added
⚠️ 1011 - SubgroupAdd oracle-database virtual-network-address sub group oracle-database virtual-network-address added

@azure-client-tools-bot-prd
Copy link

Hi @mihretkidane-OCI,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 18, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds new generated Azure CLI commands for the Oracle Database service, updating the API version from 2023-09-01 to 2025-09-01 and introducing new command groups and operations for managing Oracle database resources on Azure.

Key Changes

  • Updated API version to 2025-09-01 across multiple command modules
  • Added new command groups: exadb-vm-cluster, db-system, and db-system-db-version
  • Added show commands for dns-private-zone, dns-private-view, database-system-shape, and cloud VM cluster components
  • Introduced virtual network address management commands for cloud VM clusters
  • Added new properties and schema fields to support enhanced database configurations

Reviewed Changes

Copilot reviewed 86 out of 168 changed files in this pull request and generated no comments.

Show a summary per file
File Description
exadb_vm_cluster/_create.py New command to create ExaDB VM clusters with comprehensive configuration options
exadb_vm_cluster/_delete.py New command to delete ExaDB VM clusters
db_system/_create.py New command to create database systems
db_system/_delete.py New command to delete database systems
dns_private_zone/_show.py New command to retrieve DNS private zone details
dns_private_view/_show.py New command to retrieve DNS private view details
cloud_vm_cluster/virtual_network_address/*.py New commands for managing virtual network addresses
cloud_vm_cluster/_update.py Updated to API version 2025-09-01 with new file system configuration support
database_system_shape/_list.py Updated to API version 2025-09-01 with new filtering options

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

Hi @mihretkidane-OCI

Release Suggestions

Module: oracle-database

  • Please log updates into to src/oracle-database/HISTORY.rst
  • Update VERSION to 2.0.0 in src/oracle-database/setup.py

Notes

@necusjz necusjz assigned necusjz and unassigned evelyn-ys Nov 20, 2025
@necusjz necusjz self-requested a review November 20, 2025 23:45
@necusjz
Copy link
Member

necusjz commented Nov 20, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz
Copy link
Member

necusjz commented Nov 24, 2025

after went through the whole pull request,

  1. are the following breaking changes expected? image
  2. we'd better update setup.py and HISTORY.rst to release a new version.
  3. the new generated commands should have at least one example https://github.com/Azure/azure-cli-extensions/actions/runs/19544263033/job/55958806872?pr=9435#step:6:135.
  4. some test cases need to re-record https://dev.azure.com/azclitools/public/_build/results?buildId=283896&view=logs&j=edd23f8e-0483-53ea-dfe4-85f031ec115a&t=758d86e6-87e1-58dd-c45e-4b2170f268bc&l=1171.
  5. it's better to have more test cases due to the testing coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants