Skip to content

[AKS] update control-plane-only user confirmation prompt #9404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[AKS] update control-plane-only user confirmation prompt #9404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96e2728
update prompt
m-chau Nov 7, 2025
40611ba
update versions
m-chau Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/aks-preview/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ Pending
+++++++
* Add option `Windows2025` to `--os-sku` for `az aks nodepool add`.

18.0.0b40
+++++++
* Update user prompt for `az aks upgrade` command to clarify the implication of the `--control-plane-only` options.

18.0.0b39
+++++++
* Add option `AzureLinuxOSGuard` and `AzureLinux3OSGuard` to `--os-sku` for `az aks nodepool add` and `az aks nodepool update`.
Expand Down
6 changes: 4 additions & 2 deletions src/aks-preview/azext_aks_preview/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1260,8 +1260,10 @@ def aks_upgrade(cmd,
upgrade_all = True
else:
msg = (
"Since control-plane-only argument is specified, this will upgrade only the control plane to "
f"{instance.kubernetes_version}. Node pool will not change. Continue?"
"Since control-plane-only argument is specified, this will upgrade only the kubernetes version of the control plane to "
Copy link

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two consecutive spaces after "to" in this line. It should be "control plane to {instance.kubernetes_version}" with only one space.

Suggested change
"Since control-plane-only argument is specified, this will upgrade only the kubernetes version of the control plane to "
"Since control-plane-only argument is specified, this will upgrade only the kubernetes version of the control plane to "

Copilot uses AI. Check for mistakes.
f"{instance.kubernetes_version}. Kubernetes versions of the node pools will remain unchanged, "
"but node image version may be upgraded if there has been cluster config change that requires VM reimage. "
"Continue?"
)
if not yes and not prompt_y_n(msg, default="n"):
return None
Expand Down
2 changes: 1 addition & 1 deletion src/aks-preview/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

from setuptools import find_packages, setup

VERSION = "18.0.0b39"
VERSION = "18.0.0b40"

CLASSIFIERS = [
"Development Status :: 4 - Beta",
Expand Down
Loading