[build] add job for running MBOR types smoke tests#499
Closed
zimmy87 wants to merge 2 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds CI “smoke” coverage for MBOR types on the emulated backend by extending the xtask nextest wrapper with additional selection flags, wiring a new nextest profile for JUnit output, and introducing dedicated workflow jobs.
Changes:
- Extend
cargo xtask nextestwith--testand--filterarguments to target specific integration test binaries and name filters. - Add a Nextest profile (
ci-mbor-smoke) to emitjunit.xmlfor MBOR smoke runs. - Add Ubuntu/Windows GitHub Actions jobs intended to run MBOR types smoke tests against the emu backend.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
xtask/src/precheck.rs |
Adds an MBOR emu test run to the “run all nextest” path; updates Nextest {} literals for new fields. |
xtask/src/nextest.rs |
Adds --test and --filter to the xtask wrapper and forwards them to cargo nextest run. |
.github/workflows/rust.yml |
Adds new Ubuntu/Windows smoke jobs intended to run MBOR types smoke tests and generate reports. |
.config/nextest.toml |
Adds ci-mbor-smoke profile JUnit output configuration. |
Comment on lines
+9
to
+10
| use std::vec; | ||
|
|
Comment on lines
+215
to
+216
| test: None, | ||
| filter: vec![], |
Comment on lines
+44
to
+50
| /// Test only the specified test target | ||
| #[clap(long)] | ||
| pub test: Option<String>, | ||
|
|
||
| /// Test name filters | ||
| #[clap(long)] | ||
| pub filter: Vec<String>, |
Comment on lines
+121
to
+124
| - name: Run MBOR types smoke tests against emu backend | ||
| id: test-mbor-smoke | ||
| run: cargo xtask precheck --nextest --package azihsm_ddi_mbor_types --features emu --test azihsm_ddi_tests --filter smoke | ||
| continue-on-error: true |
Comment on lines
+128
to
+130
| - name: Code Coverage Summary Report | ||
| if: ${{ steps.test-mbor-smoke.outcome == 'success' }} | ||
| run: cargo xtask precheck --coverage-report |
Comment on lines
+216
to
+219
| - name: Run MBOR types smoke tests against emu backend | ||
| id: test-mbor-smoke | ||
| run: cargo xtask precheck --nextest --package azihsm_ddi_mbor_types --features emu --test azihsm_ddi_tests --filter smoke | ||
| continue-on-error: true |
Comment on lines
+223
to
+225
| - name: Code Coverage Summary Report | ||
| if: ${{ steps.test-mbor-smoke.outcome == 'success' }} | ||
| run: cargo xtask precheck --coverage-report |
Contributor
Author
|
closing in favor of #502 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.