Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add java-on-aca-quarkus template #462

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

majguo
Copy link
Member

@majguo majguo commented Oct 28, 2024

Please fill out this template! There are three different types of contributions, feel free to delete the checklists that are not applicable to your contribution type.

If you are submitting a new azd template to the gallery

Fill this out if you want your template to be added to the awesome-azd gallery!

Your template repository

Place your template repository link here:

  • Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/src/data/users.tsx that includes:

    • Template title - A short title that reflects the local application stack that someone could use to get their application on Azure (e.g. "Containerized React Web App with Java API and MongoDB")

    • Description - 1-2 sentence description of the architecture (e.g. Azure services) or solution that is defined by the template.

    • Architecture Diagram or Application Screenshot - The image should include all services and their connections (example). You should add the image to the website/src/data/images/.

    • Link to Author's GitHub or other relevant website - Used for attribution

    • Author's Name - Name to credit on the gallery card

    • Link to template source - Link to the template GitHub repo

    • Tags - Specify tags to represent the template. If you don't see a relevant tag for your template? Feel free to add one!

      Required tags:

      • Tag your template as Micrsoft-authored ("msft") or Community-authored ("community")
      • Tag the IaC provider ("bicep" or "terraform")
      • At least 1 tag for programming language used
      • At least 1 tag for Azure services integrated
      • Add the "new" tag for any newly authored templates
  • In the PR comment, if you can also add a link to the PR where you made your repo azd compatible this will allow us to provide feedback on your template and speed up the review process.

  • If the template is Microsoft-authored, we encourage you to also publish it to learn.microsoft.com/samples.

Signed-off-by: Jianguo Ma <[email protected]>
@majguo
Copy link
Member Author

majguo commented Oct 28, 2024

Link to the repo that is azd compatible: https://github.com/Azure-Samples/java-on-aca-quarkus

@majguo
Copy link
Member Author

majguo commented Oct 28, 2024

Hi @gkulin , @hemarina , @rajeshkamal5050 and @vhvb1989, would you help to review this PR? Thanks!

@hemarina
Copy link
Contributor

@v-xuto Could you test this template please?

@v-xuto
Copy link
Member

v-xuto commented Oct 29, 2024

@v-xuto Could you test this template please?

Testing.

@v-xuto
Copy link
Member

v-xuto commented Oct 30, 2024

@hemarina, @majguo We have finished this template test, and we filed two issues. Please review.

@majguo
Copy link
Member Author

majguo commented Oct 30, 2024

Thank you @v-xuto , will address these issues ASAP.

@majguo
Copy link
Member Author

majguo commented Oct 31, 2024

@hemarina, @majguo We have finished this template test, and we filed two issues. Please review.

@v-xuto These reported issues are fixed, could you pls re-test the template? Thanks.

@v-xuto
Copy link
Member

v-xuto commented Oct 31, 2024

@majguo Both issues have been retested and fixed.

@hemarina All issues have been fixed. There are currently no issues with this template. Please review.

@majguo
Copy link
Member Author

majguo commented Oct 31, 2024

Awesome, thank you @v-xuto.
@hemarina Pls help review and let me know if it's good to go or any comments, thanks.

@majguo
Copy link
Member Author

majguo commented Nov 1, 2024

@majguo Both issues have been retested and fixed.

@hemarina All issues have been fixed. There are currently no issues with this template. Please review.

Hi @gkulin , @hemarina , @rajeshkamal5050 and @vhvb1989, are we good to go now? Thanks.

Copy link
Contributor

@hemarina hemarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. The template will be live on Wednesday weekly release. If you would like to see it early, feel free to reach out.

@hemarina hemarina merged commit 327f480 into Azure:main Nov 1, 2024
2 checks passed
@majguo majguo deleted the add-quarkus-aca-template branch November 1, 2024 08:35
@majguo
Copy link
Member Author

majguo commented Nov 2, 2024

Thank you @hemarina. BTW, I saw you put vuejs to framework category, which makes sense as Vue.js is a web development framework. Similarly, I opened PR #464 to move angular and reactjs to framework as well, would you pls take a look?

@hemarina hemarina mentioned this pull request Jan 8, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants