Skip to content

Commit a7a177d

Browse files
authored
Merge pull request #128 from Azure/fix/enable-standardv2-workspace-testing
enable workspace testing on all V2 SKUs
2 parents 0224df0 + 3fc00b3 commit a7a177d

12 files changed

Lines changed: 20 additions & 19 deletions

src/models/resource-types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ export enum ResourceType {
4141
GraphQLResolverPolicy = 'GraphQLResolverPolicy',
4242
/** MCP (Model Context Protocol) server configuration per API. Singleton per API. */
4343
McpServer = 'McpServer',
44-
/** Premium/PremiumV2 workspace container. */
44+
/** Workspace container (Premium and all V2 SKUs). */
4545
Workspace = 'Workspace',
4646
}
4747

tests/integration/all-resource-types/Compare-ApimInstance.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -714,7 +714,7 @@ try {
714714
}
715715
}
716716
catch {
717-
Write-Host " ⚠️ Workspaces not available (requires Premium/PremiumV2): $_" -ForegroundColor Yellow
717+
Write-Host " ⚠️ Workspaces not available (requires Premium or V2 SKU): $_" -ForegroundColor Yellow
718718
}
719719

720720
# ── Summary ─────────────────────────────────────────────────────────────

tests/integration/all-resource-types/Test-ExtractedArtifact.ps1

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
Path to expected-structure.json manifest file.
2222
2323
.PARAMETER SkuName
24-
APIM SKU name (StandardV2, Developer, Premium, Standard, PremiumV2) to handle SKU-variant
24+
APIM SKU name (Developer, Premium, Standard, BasicV2, StandardV2, PremiumV2) to handle SKU-variant
2525
resources. Default: StandardV2.
2626
2727
.EXAMPLE
@@ -36,6 +36,7 @@ param(
3636
[Parameter(Mandatory)]
3737
[string]$ManifestFile,
3838

39+
[ValidateSet('Developer', 'Premium', 'Standard', 'BasicV2', 'StandardV2', 'PremiumV2')]
3940
[string]$SkuName = 'StandardV2'
4041
)
4142

tests/integration/all-resource-types/bicep/source-apim-post-activation.bicep

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
param apimName string
33

44
@description('APIM SKU name. Classic SKUs support docs/wiki/policyRestriction.')
5-
@allowed(['Developer', 'Premium', 'StandardV2', 'PremiumV2'])
5+
@allowed(['Developer', 'Premium', 'BasicV2', 'StandardV2', 'PremiumV2'])
66
param skuName string
77

88
var isClassicSku = skuName == 'Developer' || skuName == 'Premium'

tests/integration/all-resource-types/bicep/source-apim.bicep

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ param publisherEmail string
2626
@description('Publisher name shown in the developer portal.')
2727
param publisherName string = 'APIOps BVT'
2828

29-
@description('APIM SKU name. Use StandardV2/PremiumV2 for v2 tiers, or Developer/Premium/Standard for classic.')
30-
@allowed(['Developer', 'Premium', 'Standard', 'StandardV2', 'PremiumV2'])
29+
@description('APIM SKU name. Use BasicV2/StandardV2/PremiumV2 for v2 tiers, or Developer/Premium/Standard for classic.')
30+
@allowed(['Developer', 'Premium', 'Standard', 'BasicV2', 'StandardV2', 'PremiumV2'])
3131
param skuName string = 'StandardV2'
3232

3333
@description('Application Insights name for logger/diagnostic testing.')
@@ -49,7 +49,7 @@ param logAnalyticsName string = 'bvt-${uniqueString(resourceGroup().id)}-src-law
4949
var isClassicSku = skuName == 'Developer' || skuName == 'Premium' || skuName == 'Standard'
5050
var apimSkuCapacity = isClassicSku ? 1 : 1
5151
var supportsSelfHostedGateway = skuName == 'Developer' || skuName == 'Premium'
52-
var supportsWorkspaces = skuName == 'Premium' || skuName == 'PremiumV2'
52+
var supportsWorkspaces = skuName == 'Premium' || skuName == 'BasicV2' || skuName == 'StandardV2' || skuName == 'PremiumV2'
5353

5454
// Minimal but valid OpenAPI 3.0 spec
5555
var openApiSpec = '''

tests/integration/all-resource-types/bicep/target-apim.bicep

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ param publisherEmail string
3030
param publisherName string = 'APIOps BVT'
3131

3232
@description('APIM SKU name. Must match the source instance SKU.')
33-
@allowed(['Developer', 'Premium', 'Standard', 'StandardV2', 'PremiumV2'])
33+
@allowed(['Developer', 'Premium', 'Standard', 'BasicV2', 'StandardV2', 'PremiumV2'])
3434
param skuName string = 'StandardV2'
3535

3636
@description('Application Insights name for logger/diagnostic testing.')

tests/integration/all-resource-types/expected-structure.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"version": "1.0.0",
55
"skuVariants": {
66
"note": "Some resources only exist on certain SKUs",
7-
"workspaces": ["Premium", "PremiumV2"],
7+
"workspaces": ["Premium", "BasicV2", "StandardV2", "PremiumV2"],
88
"selfHostedGateways": ["Developer", "Premium"]
99
},
1010
"serviceLevelArtifacts": {
@@ -633,9 +633,9 @@
633633
}
634634
},
635635
"workspaces": {
636-
"note": "Workspaces only exist on Premium and PremiumV2 SKUs",
636+
"note": "Workspaces exist on Premium and all V2 SKUs (BasicV2, StandardV2, PremiumV2)",
637637
"skuDependent": true,
638-
"skuFilter": ["Premium", "PremiumV2"],
638+
"skuFilter": ["Premium", "BasicV2", "StandardV2", "PremiumV2"],
639639
"expected": [
640640
{
641641
"name": "src-workspace",

tests/integration/all-resource-types/phases/run-phase1-deploy-source.ps1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
APIM instance name. Default: ks-apim-bvt.
2020
2121
.PARAMETER SkuName
22-
APIM SKU. Default: StandardV2. Allowed: Developer, Premium, StandardV2, PremiumV2.
22+
APIM SKU. Default: StandardV2. Allowed: Developer, Premium, BasicV2, StandardV2, PremiumV2.
2323
2424
.PARAMETER Destroy
2525
Tear down: deletes the entire resource group.
@@ -45,7 +45,7 @@ param(
4545

4646
[string]$Location = 'eastus2',
4747

48-
[ValidateSet('Developer', 'Premium', 'Standard', 'StandardV2', 'PremiumV2')]
48+
[ValidateSet('Developer', 'Premium', 'Standard', 'BasicV2', 'StandardV2', 'PremiumV2')]
4949
[string]$SkuName = 'StandardV2',
5050

5151
[string]$ApimName,

tests/integration/all-resource-types/phases/run-phase1-deploy-target.ps1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
Azure region. Default: eastus2.
1919
2020
.PARAMETER SkuName
21-
APIM SKU. Default: StandardV2. Allowed: Developer, Premium, StandardV2, PremiumV2.
21+
APIM SKU. Default: StandardV2. Allowed: Developer, Premium, BasicV2, StandardV2, PremiumV2.
2222
#>
2323

2424
[CmdletBinding()]
@@ -31,7 +31,7 @@ param(
3131

3232
[string]$Location = 'eastus2',
3333

34-
[ValidateSet('Developer', 'Premium', 'Standard', 'StandardV2', 'PremiumV2')]
34+
[ValidateSet('Developer', 'Premium', 'Standard', 'BasicV2', 'StandardV2', 'PremiumV2')]
3535
[string]$SkuName = 'StandardV2',
3636

3737
[string]$ApimName,

tests/integration/all-resource-types/phases/run-phase1-deploy.ps1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ param(
5454
[Parameter(Mandatory)]
5555
[string]$TargetResourceGroup,
5656

57-
[ValidateSet('Developer', 'Premium', 'Standard', 'StandardV2', 'PremiumV2')]
57+
[ValidateSet('Developer', 'Premium', 'Standard', 'BasicV2', 'StandardV2', 'PremiumV2')]
5858
[string]$SkuName = 'StandardV2',
5959

6060
[string]$Location = 'eastus2',
@@ -243,7 +243,7 @@ $targetName = if ($targetOutputs -and $targetOutputs.apimServiceName.value) { $t
243243
$apimName
244244
}
245245

246-
if ($SkuName -in @('Developer', 'Premium', 'PremiumV2')) {
246+
if ($SkuName -in @('Developer', 'Premium', 'BasicV2', 'StandardV2', 'PremiumV2')) {
247247
$postActivationState = az deployment group list `
248248
--resource-group $sourceRg `
249249
--query "sort_by([?starts_with(name, 'source-apim-post-activation-')], &properties.timestamp)[-1].properties.provisioningState" `

0 commit comments

Comments
 (0)