fix: strip schemaId/typeName from operation PATCH during reconciliation (#111)

* fix: strip schemaId/typeName from operation PATCH during reconciliation

After spec import, APIM assigns its own auto-generated schema IDs to
operation request/response representations. The reconciliation PATCH was
sending the source instance's schema IDs, which don't exist on the target.
APIM silently drops schemaId/typeName when the referenced schema doesn't
exist, causing the compare phase to report missing fields.

By stripping these fields from the PATCH body, APIM retains the schema
references it assigned during its own spec import. The compare script
already normalizes auto-generated hex IDs, so both sides match.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* chore: make reconciliation comments terse

* docs: tighten reconciliation comments

* docs(squad): record schema-ref reconciliation decision

* updating cmd to create log file

* updating squad files

* skipping schema ids, doing semantic compare

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

Author: 3 people

.squad/decisions.md

@@ -2,6 +2,23 @@
 
 ## Active Decisions
 
+### 2026-06-08T18:52:23Z: Long-Term Maintainability Over Quick Fixes
+**By:** User directive (anonymized)  
+**Status:** Active directive  
+**What:** When fixing code in tests or product logic, avoid quick/easy fixes and prefer solutions optimized for long-term maintainability.
+**Why:** Establishes a durable engineering quality standard and reduces short-lived patchwork changes.
+
+### 2026-06-08T18:50:20Z: Round-Trip Test Default Execution Standard
+**By:** User directive (anonymized)  
+**Status:** Active directive  
+**What:** When the user asks to run the round-trip test, follow the workflow documented in `tests/integration/all-resource-types/README.md` Quick Commands, default to StandardV2 SKU, and always save the log. Use Premium SKU only when branch-specific changes require Premium-only coverage.
+**Why:** Enforces consistent execution defaults and reliable log capture for repeatable integration test runs.
+
+### 2026-06-05T23:40:00Z: Operation reconciliation PATCH strips schema refs
+**By:** ApimExpert + TypeScriptDev  
+**Status:** Implemented  
+**What:** `reconcileOperationsAfterSpecImport` removes `schemaId` and `typeName` from operation `request.representations` and `responses[].representations` before PATCH.
+**Why:** Those IDs are source-instance specific. After target spec import, APIM assigns its own schema IDs; sending stale source IDs causes APIM to drop schema refs.
 ### 2026-07-15: PR #102 Metadata Correction
 **By:** GitHubExpert  
 **Status:** Applied (partial)  

src/services/api-publisher.ts

@@ -437,6 +437,9 @@ async function reconcileOperationsAfterSpecImport(
       }
     }
 
+    // Strip source schema refs; APIM rebinds on import and drops stale IDs.
+    stripRepresentationSchemaRefs(patchProps);
+
     if (Object.keys(patchProps).length === 0) return;
 
     const patchBody: Record<string, unknown> = { properties: patchProps };
@@ -459,6 +462,39 @@ async function reconcileOperationsAfterSpecImport(
   }
 }
 
+/** Strip source schema refs from request/response representations before PATCH. */
+function stripRepresentationSchemaRefs(patchProps: Record<string, unknown>): void {
+  const SCHEMA_REF_FIELDS = ['schemaId', 'typeName'];
+
+  function stripFromRepresentations(representations: unknown): void {
+    if (!Array.isArray(representations)) return;
+    for (const rep of representations) {
+      if (rep && typeof rep === 'object') {
+        for (const field of SCHEMA_REF_FIELDS) {
+          delete (rep as Record<string, unknown>)[field];
+        }
+      }
+    }
+  }
+
+  // Strip schema refs from request.representations.
+  const request = patchProps.request;
+  if (request && typeof request === 'object') {
+    const req = request as Record<string, unknown>;
+    stripFromRepresentations(req.representations);
+  }
+
+  // Strip schema refs from responses[].representations.
+  const responses = patchProps.responses;
+  if (Array.isArray(responses)) {
+    for (const response of responses) {
+      if (response && typeof response === 'object') {
+        stripFromRepresentations((response as Record<string, unknown>).representations);
+      }
+    }
+  }
+}
+
 /**
  * Extract revision number from API name (e.g., "my-api;rev=2" -> 2)
  */