MAINT: Remove Orchestrator and Prompt Target with Support
#752
+22
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nina-msft
changed the title
with Support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disposing of central memory database engines as part of the
__exit__can cause problems for multi-threaded programs that are using one centralized database. This PR also removes the__enter__functions from Orchestrator and Prompt Target base classes as it is the expectation to dispose of the engine as part of the Jupyter notebook cleanup.This change will require uses of Orchestrator and Prompt Target to explicitly dispose of the engine when they are done with it, and will not support the use of
withwith those classes.Tests and Documentation