Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX make sure conversation IDs are not sent out as UUIDs to the database #723

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ayeganov
Copy link
Contributor

Description

When interacting with PostgreSQL I ran into a problem of db exceptions because conversation ids were being created as uuids and eventually those values were being sent to memory_interface functions where the conversation of uuid to str was not happening and the DB was raising exceptions of incompatible types. Converting those ids to str type resolved this problem.

Tests and Documentation

@romanlutz
Copy link
Contributor

@ayeganov thanks for the fix! Could you create a test case where you provide IDs of various input types and then assert that what's passed in the (mocked) DB call is actually string? If you want me to elaborate or point you to examples please lmk!

@ayeganov
Copy link
Contributor Author

@ayeganov thanks for the fix! Could you create a test case where you provide IDs of various input types and then assert that what's passed in the (mocked) DB call is actually string? If you want me to elaborate or point you to examples please lmk!

Will do!

@romanlutz romanlutz changed the title make sure conv ids are not sent out as UUIDs to db FIX make sure conversation IDs are not sent out as UUIDs to the database Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants