FEAT Video Converter: Adding Images to Videos #702
+375
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbolor21
changed the title
rdheekonda
reviewed
Feb 11, 2025
rdheekonda
reviewed
Feb 11, 2025
rdheekonda
reviewed
Feb 11, 2025
rdheekonda
reviewed
Feb 11, 2025
rdheekonda
reviewed
Feb 11, 2025
rdheekonda
reviewed
Feb 11, 2025
rdheekonda
reviewed
Feb 11, 2025
romanlutz
reviewed
Feb 18, 2025
pyproject.toml
Outdated
| @@ -58,6 +58,7 @@ dependencies = [ | |||
| "ipykernel>=6.29.4", | |||
| "numpy>=1.26.4", | |||
| "openai>=1.58.1", | |||
| "opencv-python>=4.11.0.86", | |||
There was a problem hiding this comment.
Can you figure out what this pulls in? Might be a rather heavyweight package. If you're not sure how please lmk and we can do it together 🙂
added 6 commits
February 25, 2025 14:37
…dagdorj/video_converter
…dagdorj/video_converter
…dagdorj/video_converter
jbolor21
changed the title
nina-msft
reviewed
Feb 26, 2025
nina-msft
reviewed
Feb 26, 2025
nina-msft
reviewed
Feb 26, 2025
nina-msft
reviewed
Feb 26, 2025
nina-msft
reviewed
Feb 26, 2025
nina-msft
reviewed
Feb 26, 2025
nina-msft
reviewed
Feb 26, 2025
nina-msft
reviewed
Feb 26, 2025
nina-msft
reviewed
Feb 26, 2025
added 8 commits
February 26, 2025 17:56
…dagdorj/video_converter
…dagdorj/video_converter
nina-msft
reviewed
Mar 3, 2025
| self._img_resize_size = img_resize_size | ||
| self._video_path = video_path | ||
|
|
||
| async def _add_image_to_video(self, image_path: str, output_path: str): |
There was a problem hiding this comment.
suggest async def _add_image_to_video(self, image_path: str, output_path: str) -> str:
nina-msft
approved these changes
Mar 3, 2025
nina-msft
reviewed
Mar 3, 2025
| initialize_pyrit(memory_db_type=IN_MEMORY) | ||
|
|
||
| input_video = str(pathlib.Path(".") / ".." / ".." / ".." / "assets" / "sample_video.mp4") | ||
| output_video = str(pathlib.Path(".") / ".." / ".." / ".." / "assets" / "sample_output_video.mp4") |
There was a problem hiding this comment.
this output_video path isn't being used right now, make sure to include it in the converter init on L26
jsong468
reviewed
Mar 3, 2025
|
|
||
| async def convert_async(self, *, prompt: str, input_type: PromptDataType = "image_path") -> ConverterResult: | ||
| """ | ||
| Converter that adds an image to a video |
There was a problem hiding this comment.
NIT:
Suggested change
| Converter that adds an image to a video | |
| Adds input image to video |
jsong468
reviewed
Mar 3, 2025
jsong468
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding new video converter to add image to video
Tests and Documentation
Made new notebook and ran