New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated testing for exec docs using IE #242

Merged

naman-msft merged 8 commits into main from naman

Nov 18, 2024

Collaborator

naman-msft commented Nov 12, 2024

Attached github action and its instructions for automated testing of exec docs

root added 2 commits

November 12, 2024 14:14


          added instructions on the github action for automated testing of exec…

e368809

… docs using IE and the github action itself


          added comments to the gh action to make it easier for users to unders…

1943aa4

…tand it from the file itself

naman-msft temporarily deployed to ScenarioTesting

November 12, 2024 22:18

— with

GitHub Actions Inactive

vmarcella reviewed

View reviewed changes

examples/test-exec-doc.yml Outdated Show resolved Hide resolved

vmarcella reviewed

View reviewed changes

examples/test-exec-doc.yml Outdated Show resolved Hide resolved

vmarcella reviewed

View reviewed changes

examples/test-exec-doc.yml Outdated Show resolved Hide resolved

vmarcella reviewed

View reviewed changes

examples/test-exec-doc.yml Outdated Show resolved Hide resolved

vmarcella reviewed

View reviewed changes

examples/test-exec-doc.yml Outdated Show resolved Hide resolved

vmarcella reviewed

View reviewed changes

examples/test-exec-doc.yml Outdated Show resolved Hide resolved

vmarcella reviewed

View reviewed changes

examples/test-exec-doc.yml Outdated Show resolved Hide resolved

vmarcella reviewed

View reviewed changes

examples/test-exec-doc.yml Outdated Show resolved Hide resolved

vmarcella reviewed

View reviewed changes

examples/test-exec-doc.yml Outdated Show resolved Hide resolved

vmarcella reviewed

View reviewed changes

examples/test-exec-doc.yml Outdated Show resolved Hide resolved

vmarcella reviewed

View reviewed changes

examples/test-exec-doc.yml Outdated Show resolved Hide resolved

vmarcella reviewed

View reviewed changes

examples/test-instructions.md Outdated Show resolved Hide resolved

vmarcella reviewed

View reviewed changes

examples/test-instructions.md Outdated Show resolved Hide resolved

vmarcella requested changes

View reviewed changes

Member

vmarcella left a comment

Left some comments about what needs to be changed before it can be merged in, but will review it again after everything has been resolved.


          updated exec doc testing action and instruction addressing the PR review

34ed78b

naman-msft temporarily deployed to ScenarioTesting

November 13, 2024 07:33

— with

GitHub Actions Inactive


          finalized action

naman-msft temporarily deployed to ScenarioTesting

November 13, 2024 07:36

— with

GitHub Actions Inactive

vmarcella requested changes

View reviewed changes

Member

vmarcella left a comment

Still needs a few more changes, but it's getting closer to being ready for approval

examples/test-exec-doc.yml Outdated Show resolved Hide resolved

examples/test-exec-doc.yml Outdated Show resolved Hide resolved

examples/test-exec-doc.yml Outdated Show resolved Hide resolved

examples/test-exec-doc.yml Outdated Show resolved Hide resolved

examples/test-exec-doc.yml Outdated Show resolved Hide resolved

examples/test-exec-doc.yml Outdated Show resolved Hide resolved

examples/test-exec-doc.yml Outdated Show resolved Hide resolved

examples/test-exec-doc.yml Outdated Show resolved Hide resolved

examples/test-instructions.md Outdated Show resolved Hide resolved


          updated action and instructions based on PR review

c46a4f7

naman-msft temporarily deployed to ScenarioTesting

November 13, 2024 18:06

— with

GitHub Actions Inactive

vmarcella requested changes

View reviewed changes

Member

vmarcella left a comment

Continued discussing the open thread but didn't add any further comments. Not relevant to the work itself, but do you think you could actually add another folder called test-exec-doc or something along those lines, move the files into there, and then rename test-instructions.md to README.md? We will have other examples in the future, and this will also allow for your readme to be viewed directly on github as soon as someone enters the example directory.

examples/test-exec-doc.yml Outdated Show resolved Hide resolved

examples/test-exec-doc.yml Outdated Show resolved Hide resolved

examples/test-exec-doc.yml Outdated Show resolved Hide resolved

examples/test-exec-doc.yml Outdated Show resolved Hide resolved


          updated action and instructions following PR review

a2cdd70

naman-msft temporarily deployed to ScenarioTesting

November 14, 2024 04:44

— with

GitHub Actions Inactive


          updated dependencies version numbers

aa3f250

naman-msft temporarily deployed to ScenarioTesting

November 14, 2024 17:34

— with

GitHub Actions Inactive

vmarcella previously approved these changes

View reviewed changes


          updated action and instructions

0f2d850

naman-msft dismissed vmarcella’s stale review via

0f2d850

November 18, 2024 15:45

naman-msft temporarily deployed to ScenarioTesting

November 18, 2024 15:45

— with

GitHub Actions Inactive

vmarcella approved these changes

View reviewed changes

naman-msft added this pull request to the merge queue

Merged via the queue into main with commit 1acf6d7

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet