Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow for tagged release #167

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Add workflow for tagged release #167

merged 4 commits into from
Jan 31, 2024

Conversation

rguptar
Copy link
Collaborator

@rguptar rguptar commented Jan 26, 2024

No description provided.

@rguptar rguptar temporarily deployed to ScenarioTesting January 26, 2024 21:34 — with GitHub Actions Inactive
@@ -1,24 +1,29 @@
# Script to install scenarios file. Pass in language code parameter for a particular language, such as it-it for Italian.
set -e

# Define the language parameter
# TODO: make parameters mandatory
LANG="$1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a step to our primary testing pipeline which makes sure that the installation script always works and does a few things? The two things I have in mind for the test are to check if:

  1. Installs IE on to the PATH
  2. Can access the scenarios folder

@rguptar rguptar temporarily deployed to ScenarioTesting January 30, 2024 21:33 — with GitHub Actions Inactive
@rguptar rguptar temporarily deployed to ScenarioTesting January 30, 2024 21:38 — with GitHub Actions Inactive
@rguptar rguptar requested a review from vmarcella January 30, 2024 21:43
@rguptar rguptar added this pull request to the merge queue Jan 31, 2024
Merged via the queue into main with commit 7cc4b63 Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants