Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Created AI Converter + Added Static Web App Exec Doc #126

Merged
merged 27 commits into from
Jan 31, 2024
Merged

Conversation

naman-msft
Copy link
Collaborator

Created the static web app exec doc with the similarity blocks generated by AI. It works now. Had to get modify the original Azure doc to get around the Git authentication part, which could be reinstated once we allow users to add variables while running the exec doc. Let me know if there are any comments or question!

mbifeld
mbifeld previously requested changes Nov 1, 2023
Copy link
Member

@mbifeld mbifeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure we use generic environment variables and random postfixes.
The webapp 'show' command at the end doesn't ensure a valid output. You can also curl as an option. See LAMP doc for an example.
Echo the url to the user at the end like in LAMP/AKS docs.
Delete the AI's message at the end about the markdown being useful.

@naman-msft
Copy link
Collaborator Author

made the changes and pushed with updates

@naman-msft
Copy link
Collaborator Author

@vmarcella: how to troubleshoot this part of the code where I am replicating the curl command to see if the website is live and working but it keeps running in my local ubuntu terminal although a valid URL has been generated.


  1. Validate that the static web app is running by curling the application url:
runtime="5 minute";
endtime=$(date -ud "$runtime" +%s);
while [[ $(date -u +%s) -le $endtime ]]; do
    if curl -L -s -f $MY_STATIC_WEB_APP_URL > /dev/null ; then 
      curl -L -s -f $MY_STATIC_WEB_APP_URL > /dev/null | head -n 9
      break
    else
      echo "Waiting for the static web app to be deployed..." 
      sleep 10
    fi;
done

Results:

<!DOCTYPE html>
<html lang=en>
<head>
<meta charset=utf-8 />
<meta name=viewport content="width=device-width, initial-scale=1.0" />
<meta http-equiv=X-UA-Compatible content="IE=edge" />
<title>Azure Static Web Apps - Welcome</title>
<link rel="shortcut icon" href=https://appservice.azureedge.net/images/static-apps/v3/favicon.svg type=image/x-icon />
<link rel=stylesheet href=https://ajax.aspnetcdn.com/ajax/bootstrap/4.1.1/css/bootstrap.min.css crossorigin=anonymous />

@mbifeld
Copy link
Member

mbifeld commented Nov 20, 2023

@vmarcella: how to troubleshoot this part of the code where I am replicating the curl command to see if the website is live and working but it keeps running in my local ubuntu terminal although a valid URL has been generated.

  1. Validate that the static web app is running by curling the application url:
runtime="5 minute";
endtime=$(date -ud "$runtime" +%s);
while [[ $(date -u +%s) -le $endtime ]]; do
    if curl -L -s -f $MY_STATIC_WEB_APP_URL > /dev/null ; then 
      curl -L -s -f $MY_STATIC_WEB_APP_URL > /dev/null | head -n 9
      break
    else
      echo "Waiting for the static web app to be deployed..." 
      sleep 10
    fi;
done

Results:

<!DOCTYPE html>
<html lang=en>
<head>
<meta charset=utf-8 />
<meta name=viewport content="width=device-width, initial-scale=1.0" />
<meta http-equiv=X-UA-Compatible content="IE=edge" />
<title>Azure Static Web Apps - Welcome</title>
<link rel="shortcut icon" href=https://appservice.azureedge.net/images/static-apps/v3/favicon.svg type=image/x-icon />
<link rel=stylesheet href=https://ajax.aspnetcdn.com/ajax/bootstrap/4.1.1/css/bootstrap.min.css crossorigin=anonymous />

Have you made any progress on this issue @naman-msft?

@naman-msft naman-msft enabled auto-merge December 6, 2023 17:11
@mbifeld
Copy link
Member

mbifeld commented Dec 6, 2023

The converter files should not be in the top level of the repo, they should be in a specific folder. Can you also add to the description of the PR the AI converter changes? Right now it appears that the PR is just for the static web app.

@naman-msft naman-msft changed the title [RFC] Created Static Web App Exec Doc (using AI) [RFC] Created AI Converter + Added Static Web App Exec Doc Dec 6, 2023
@naman-msft
Copy link
Collaborator Author

The converter files should not be in the top level of the repo, they should be in a specific folder. Can you also add to the description of the PR the AI converter changes? Right now it appears that the PR is just for the static web app.

@naman-msft naman-msft closed this Dec 6, 2023
auto-merge was automatically disabled December 6, 2023 20:04

Pull request was closed

@naman-msft naman-msft reopened this Dec 6, 2023
@naman-msft naman-msft enabled auto-merge December 6, 2023 22:13
@vmarcella vmarcella self-requested a review December 6, 2023 23:19
@naman-msft naman-msft added this pull request to the merge queue Jan 31, 2024
Merged via the queue into main with commit b93f70a Jan 31, 2024
@vmarcella vmarcella deleted the naman_code branch February 6, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants