Add a boolean property to 4 components to know if it is a multi tenancy instance. #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gklijs
requested review from
CodeDrivenMitch,
corradom,
sandjelkovic,
smcvb and
stefanmirkovic
and removed request for
a team
smcvb
approved these changes
Aug 9, 2024
Contributor
smcvb
left a comment
smcvb
left a comment
There was a problem hiding this comment.
Upgrading to 1.8.0 doesn't seem weird to me!
And, approved 👍
CodeDrivenMitch
requested changes
Aug 9, 2024
Collaborator
CodeDrivenMitch
left a comment
CodeDrivenMitch
left a comment
There was a problem hiding this comment.
We need some changes for backwards compat first, other than that it looks good.
Indeed looks like 1.8.0 to me!
...e-framework-client-api/src/main/java/io/axoniq/console/framework/api/clientIdentification.kt
Outdated
Show resolved
Hide resolved
…ramework/api/clientIdentification.kt Co-authored-by: Mitchell Herrijgers <[email protected]>
|
CodeDrivenMitch
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this changes the client API, maybe we should change the milestone to 1.8.0?