fix: correct README structure and add billing conformance check#37
Merged
George-iam merged 3 commits intomainfrom Mar 8, 2026
Merged
fix: correct README structure and add billing conformance check#37George-iam merged 3 commits intomainfrom
George-iam merged 3 commits intomainfrom
Conversation
…heck README: replace the stale checks/fixtures/runner.py directory tree with the real structure (suite.py flat layout). Remove broken link to non-existent docs/coverage-matrix.md; replace with inline prose describing actual coverage status including the billing gap. suite.py: add _check_enterprise_billing_contract covering PATCH/GET /v1/billing/plan and GET /v1/billing/invoices — the only API family that previously had zero conformance checks. Made-with: Cursor
The happy-path and reports-failures test harnesses hardcode the expected number of ContractResults. Adding enterprise_billing raised that count from 44 to 45. Also add mock handlers for PATCH/GET /v1/billing/plan and GET /v1/billing/invoices so the happy-path test passes. Made-with: Cursor
GET /v1/billing/plan returns the current plan for the org/workspace — it doesn't have to carry the same plan_id that was just returned by the PATCH upsert (implementations may store one plan per scope). Check that plan_id is a string, not that it equals the upsert response id. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Made with Cursor