Define stable health response structure for network-node crate - #350
Merged
El-swaggerito merged 1 commit intoAug 23, 2026
Merged
Conversation
- Add HealthResponse struct with status, service_name, version, and environment fields - Implement health_status() function returning structured response - Support JSON serialization/deserialization via serde - Add comprehensive test coverage for happy path, edge cases, and serialization - All tests pass: cargo fmt, cargo check, cargo test, cargo clippy validation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #338
Define stable health response structure for network-node crate
Summary
Establishes a predictable, structured health check response for the network-node library to support downstream tooling integration.
Changes
HealthResponse struct: Defines stable response shape with four fields:
status: Health check status (currently "ok")service_name: Identifies the service ("axionvera-network-node")version: Package version from Cargo.tomlenvironment: Optional network/environment identifierhealth_status() function: Returns structured HealthResponse with optional environment parameter
Serialization support: Full serde integration for JSON serialization/deserialization
Comprehensive test suite: 18 tests covering:
Testing
cargo fmtcomplies with style guidelinescargo checkverifies compilationcargo clippypasses linter checksNotes