Fix icon refresh event in systray #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Edit: Nvm, misread the diff, but I do wonder how related the issue could be |
|
Excellent. Truly excellent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_refresh_item_ui wasn't getting connected to the event, because of a typo it seems. Fixing that and removing the poll event that triggers every second lowers CPU usage. This is because calling _get_item_pixbuf every second for every icon is somewhat expensive.
With cava disabled and a fix to fabric, I'm sitting at 0% CPU usage for ax-shell at idle most of the time on my system. There might still be something that is polling every second but haven't yet figured out what that is.