Closed
Conversation
Member
|
Closing this because it's incompatible with v4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a filter to check if a given block was placed by the player themself, not just by any player. It functions using the same basic functionality as "player_placed".
What good is a self_placed filter?
How does it work?
The implementation relies on Auxilor/eco#243 this pull request.
TL;DR -- eco currently stores an integer "1" for any block placed by a player. The actual value stored is never checked, just its existence. I've taken advantage of that to store a value identifying the placing player instead.