FIX: Trying to fix duplication drop issue#192
Open
kiriharu wants to merge 1 commit intoAuxilor:masterfrom
Open
FIX: Trying to fix duplication drop issue#192kiriharu wants to merge 1 commit intoAuxilor:masterfrom
kiriharu wants to merge 1 commit intoAuxilor:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation:
Every time, when I break blocks with active
multiply_dropseffect I get much more drops then expected.For example, if I have this config:
I expect to get 2 raw iron, but instead, I get 512 + 2.
Same issue when I use
fortuneargument.I spent some time in debugger and found a solution - when EditableBlockDropEvent#items clear all modifiers after itemstack modification - all works as expected. But I don't think it's right, because I don't fully understand architecture.