Update build.yml to correct data paths for PyInstaller#10
Conversation
WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub Actions
participant PyInstaller
participant Build Artifacts
GitHub Actions->>PyInstaller: Run build with --add-data templates:templates
PyInstaller-->>Build Artifacts: Bundle templates directory
Build Artifacts-->>GitHub Actions: Upload build artifacts
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/build.yml (1)
36-38: Inconsistent-Fusage between macOS and other targetsAll Linux / Windows builds package a single-file executable with
-F, whereas both macOS jobs omit it.
If the intention is to ship the same artefact shape across platforms (easier release & download workflow), add-Fhere as well; if not, document the reason to avoid future confusion.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/build.yml(6 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build-linux-arm
- GitHub Check: build-windows-arm
Summary by CodeRabbit