Add missing write_bool_input method to SafeBufferAccess#46
Merged
Conversation
Co-Authored-By: Thiago Alves <thiagoralves@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the missing
write_bool_inputmethod to theSafeBufferAccessclass. This method was inadvertently omitted when thewrite_*_inputmethods were added in a previous commit, causing runtime errors when the Modbus master plugin attempts to write boolean values to PLC input buffers (e.g.,%IXaddresses).Error being fixed:
The new method follows the same pattern as
write_bool_outputand otherwrite_*_inputmethods.Review & Testing Checklist for Human
modbus_master_memory.py(lines 270, 540) - expects(buffer_idx, bit_idx, value, thread_safe=False)%IX) to confirm the error is resolvedtests/pytest/modbus_master/test_modbus_slave_device.pywhich expects this method to existRecommended test plan: Deploy a runtime container built from this branch and run a PLC program that uses Modbus master to write to
%IXaddresses. Thewrite_preconverted_iec_valueserror should no longer occur.Notes