Skip to content

Generate modbus master config for RTU devices #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
intmech wants to merge 9 commits into
base: development
Choose a base branch
from
Open

Generate modbus master config for RTU devices #723

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
083ff2c
Merge pull request #459 from Autonomy-Logic/development
thiagoralves Dec 3, 2025
8c2c0de
Merge branch 'development'
JoaoGSP Jan 30, 2026
be55f44
Merge branch 'development' - fix release workflow version
thiagoralves Jan 31, 2026
065c3ab
Merge pull request #626 from Autonomy-Logic/development
thiagoralves Feb 25, 2026
c499b8a
Merge remote-tracking branch 'origin/development'
thiagoralves Feb 26, 2026
7059c22
Merge remote-tracking branch 'origin/development'
thiagoralves Feb 27, 2026
d9a7cac
Generate modbus master config for RTU devices
intmech Apr 10, 2026
71d4169
Require explicit RTU serial port configuration
intmech Apr 13, 2026
1987c2c
Surface RTU config warnings in compiler output
intmech Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/modules/compiler/compiler-module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1215,7 +1215,7 @@ class CompilerModule {
await writeFile(configFilePath, modbusMasterConfig, 'utf-8')
handleOutputData('Generated conf/modbus_master.json', 'info')
} else {
handleOutputData('No Modbus TCP remote devices configured, skipping modbus_master.json generation', 'info')
handleOutputData('No Modbus remote devices configured, skipping modbus_master.json generation', 'info')
}
}

Expand Down
15 changes: 4 additions & 11 deletions src/utils/modbus/generate-modbus-master-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ interface ModbusMasterIOPoint {

// Base device config with common fields
interface ModbusMasterDeviceConfigBase {
type: 'SLAVE'
type: 'MASTER'
transport: 'tcp' | 'rtu'
timeout_ms: number
slave_id: number
Expand Down Expand Up @@ -100,20 +100,13 @@ const convertRemoteDeviceToModbusMaster = (device: PLCRemoteDevice): ModbusMaste
const transport = modbusTcpConfig.transport || 'tcp'

if (transport === 'rtu') {
// RTU configuration
if (!modbusTcpConfig.serialPort) {
// RTU requires a serial port
console.warn(`Modbus RTU device "${device.name}" is missing a serial port configuration and will be skipped.`)
return null
}

return {
name: device.name,
protocol: 'MODBUS',
config: {
type: 'SLAVE',
type: 'MASTER',
transport: 'rtu',
serial_port: modbusTcpConfig.serialPort,
serial_port: modbusTcpConfig.serialPort ?? '/dev/ttyUSB0',
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
baud_rate: modbusTcpConfig.baudRate ?? 9600,
parity: modbusTcpConfig.parity ?? 'N',
stop_bits: modbusTcpConfig.stopBits ?? 1,
Expand All @@ -129,7 +122,7 @@ const convertRemoteDeviceToModbusMaster = (device: PLCRemoteDevice): ModbusMaste
name: device.name,
protocol: 'MODBUS',
config: {
type: 'SLAVE',
type: 'MASTER',
transport: 'tcp',
host: modbusTcpConfig.host ?? '127.0.0.1',
port: modbusTcpConfig.port ?? 502,
Expand Down