-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Error that could occur when loading compiled CSS. #98708
Fix: Error that could occur when loading compiled CSS. #98708
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
I'm not sure how to test the verbum-editor itself, but importing directly the CSS files is a no-risk change (I've built Gutenberg locally and checked the imported CSS files do exist). This is what I've done for testing:
The However, the app runs out of memory and won't start:
|
5bfb601
to
e00d3ed
Compare
Closing this PR as the fix was merged as part of the package upgrade PR. |
During the package upgrade #96470 after rebasing the PR we start getting the following error:
This is similar to the error in Gutenberg that affected the storybook and was fixed at WordPress/gutenberg#68526.
We were importing some built styles without the CSS prefix, these caused the files to be interpreted as scss which causes the built error.
Proposed Changes
We apply the same change done at WordPress/gutenberg#68526 and added the CSS prefix to the imports causing the error.
Testing Instructions
Verify yarn and yarn start work as expected.
More testing instructions will be included.