Move remaining screen options logic to Screen_Options class #1957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transferred the handling of screen options and submit button display from Settings to Screen_Options for better separation of concerns and maintainability. Removed related methods and filters from Settings and added them to Screen_Options.
There was a problem hiding this comment.
Pull Request Overview
This PR continues the refactoring effort from #1925 by moving screen options functionality from the Settings class to the Screen_Options class for better code organization and separation of concerns.
- Moved
add_screen_optionandscreen_options_show_submitmethods from Settings to Screen_Options class - Removed explanatory paragraph from the screen options HTML output
- Updated WordPress action/filter hooks to point to the new class methods
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| includes/wp-admin/class-settings.php | Removed screen options filter hooks and deleted the add_screen_option and screen_options_show_submit methods |
| includes/wp-admin/class-screen-options.php | Added the screen options filter hooks and implemented the add_screen_option and screen_options_show_submit methods |
obenland
added
the
Skip Changelog
pfefferle
reviewed
Jul 18, 2025
pfefferle
previously approved these changes
Jul 18, 2025
Co-authored-by: Matthias Pfefferle <[email protected]>
pfefferle
reviewed
Jul 18, 2025
pfefferle
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1925.
Proposed changes: