-
Notifications
You must be signed in to change notification settings - Fork 4
Build the app before running the prep-release script #1477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Size Change: 0 B Total Size: 197 kB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean that we have to remove the node modules directory, so that it isn't packaged up in the release afterwards?
The |
I simulated a pre-release by bumping the version and updating the changelog, but exited the process before creating the pull request. diff --git a/.sshyncignore b/.sshyncignore
new file mode 100644
index 0000000..353e57b
--- /dev/null
+++ b/.sshyncignore
@@ -0,0 +1,7 @@
+.git
+node_modules/
+tests/
+vendor/
+.cache/
+.idea
+.config It seems that the Git commands in these scripts are adding files that were not initially tracked, Other than that, LGTM! |
|
@markbiek, since you've worked on the script before, could you confirm if it's ok to build the app before running the |
Changes proposed in this Pull Request:
The
update-translationscommand of theprep-releasescript will scan the directory for translatable strings, including thebuilddirectory, which can either be outdated or not existing at all, resulting in excluding strings from the generated POT file.This PR updates the
npm run prepare-releasescript to addnpm run buildprior to executing theprep-release.jsscript to ensure the build directory is up to date when scanning for translatable strings.How to test the changes in this Pull Request:
Other information:
FOR PR REVIEWER ONLY: