Skip to content

Conversation

ingeniumed
Copy link
Contributor

@ingeniumed ingeniumed commented Oct 27, 2023

Description

This will upgrade all the packages to the latest versions, and incorporates any fixes needed for them.

What I found:

  • extend-expect has been removed so i dropped that part of the import. In case a replacement is needed, there is one I have in mind but I haven't used it. Check this out.
  • Added "@typescript-eslint/eslint-plugin": "^6.9.0" & "@typescript-eslint/parser": "^6.9.0", in order to ensure the underlying version used was correct. It was using 5.12 previously.

In addition, it also updates the node versions to test against in the CircleCI config. That's set to Node 20 and Node 18. I can add Node 16 back if need be.

@ingeniumed ingeniumed requested review from chriszarate and a team October 27, 2023 04:59
Copy link
Contributor

@alecgeatches alecgeatches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I'm surprised we're still using CircleCI here as we're mostly GitHub Actions most other places. Would it make sense to add a backlog item to move these over?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants