Database configuration and migration

.github/workflows/verify-version.yml

@@ -0,0 +1,35 @@
+name: Verify plugin version
+
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+
+jobs:
+  verify-version:
+    name: Assert the WordPress plugin header declares the same version as the SQLITE_DRIVER_VERSION constant
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Extract version from "load.php"
+        id: load_version
+        run: |
+          VERSION=$(grep "Version:" load.php | sed "s/.*Version: \([^ ]*\).*/\1/")
+          echo "load_version=$VERSION" >> $GITHUB_OUTPUT
+
+      - name: Extract version from "version.php"
+        id: const_version
+        run: |
+          VERSION=$(php -r "require 'version.php'; echo SQLITE_DRIVER_VERSION;")
+          echo "const_version=$VERSION" >> $GITHUB_OUTPUT
+
+      - name: Compare versions
+        run: |
+          if [ "${{ steps.load_version.outputs.load_version }}" != "${{ steps.const_version.outputs.const_version }}" ]; then
+            echo "Version mismatch detected!"
+            echo "  load.php version:     ${{ steps.load_version.outputs.load_version }}"
+            echo "  version.php constant: ${{ steps.const_version.outputs.const_version }}"
+            exit 1
+          fi

load.php

@@ -12,6 +12,12 @@
  * @package wp-sqlite-integration
  */
 
+/**
+ * Load the "SQLITE_DRIVER_VERSION" constant.
+ * This constant needs to be updated on plugin release!
+ */
+require_once __DIR__ . '/version.php';
+
 define( 'SQLITE_MAIN_FILE', __FILE__ );
 
 require_once __DIR__ . '/php-polyfills.php';

tests/WP_SQLite_Driver_Metadata_Tests.php

@@ -1,44 +1,20 @@
 <?php
 
-require_once __DIR__ . '/../wp-includes/sqlite-ast/class-wp-sqlite-driver.php';
-require_once __DIR__ . '/../wp-includes/sqlite-ast/class-wp-sqlite-driver-exception.php';
-require_once __DIR__ . '/../wp-includes/sqlite-ast/class-wp-sqlite-information-schema-builder.php';
-
 use PHPUnit\Framework\TestCase;
 
 class WP_SQLite_Driver_Metadata_Tests extends TestCase {
-
+	/** @var WP_SQLite_Driver */
 	private $engine;
-	private $sqlite;
 
-	public static function setUpBeforeClass(): void {
-		// if ( ! defined( 'PDO_DEBUG' )) {
-		// define( 'PDO_DEBUG', true );
-		// }
-		if ( ! defined( 'FQDB' ) ) {
-			define( 'FQDB', ':memory:' );
-			define( 'FQDBDIR', __DIR__ . '/../testdb' );
-		}
-		error_reporting( E_ALL & ~E_DEPRECATED );
-		if ( ! isset( $GLOBALS['table_prefix'] ) ) {
-			$GLOBALS['table_prefix'] = 'wptests_';
-		}
-		if ( ! isset( $GLOBALS['wpdb'] ) ) {
-			$GLOBALS['wpdb']                  = new stdClass();
-			$GLOBALS['wpdb']->suppress_errors = false;
-			$GLOBALS['wpdb']->show_errors     = true;
-		}
-		return;
-	}
+	/** @var PDO */
+	private $sqlite;
 
 	// Before each test, we create a new database
 	public function setUp(): void {
 		$this->sqlite = new PDO( 'sqlite::memory:' );
 		$this->engine = new WP_SQLite_Driver(
-			array(
-				'connection' => $this->sqlite,
-				'database'   => 'wp',
-			)
+			new WP_SQLite_Connection( array( 'pdo' => $this->sqlite ) ),
+			'wp'
 		);
 	}
 

tests/WP_SQLite_Driver_Query_Tests.php

@@ -1,38 +1,16 @@
 <?php
 
-require_once __DIR__ . '/../wp-includes/sqlite-ast/class-wp-sqlite-driver.php';
-require_once __DIR__ . '/../wp-includes/sqlite-ast/class-wp-sqlite-driver-exception.php';
-require_once __DIR__ . '/../wp-includes/sqlite-ast/class-wp-sqlite-information-schema-builder.php';
-
 use PHPUnit\Framework\TestCase;
 
 /**
  * Unit tests using the WordPress table definitions.
  */
 class WP_SQLite_Driver_Query_Tests extends TestCase {
-
+	/** @var WP_SQLite_Driver */
 	private $engine;
-	private $sqlite;
 
-	public static function setUpBeforeClass(): void {
-		// if ( ! defined( 'PDO_DEBUG' )) {
-		// define( 'PDO_DEBUG', true );
-		// }
-		if ( ! defined( 'FQDB' ) ) {
-			define( 'FQDB', ':memory:' );
-			define( 'FQDBDIR', __DIR__ . '/../testdb' );
-		}
-		error_reporting( E_ALL & ~E_DEPRECATED );
-		if ( ! isset( $GLOBALS['table_prefix'] ) ) {
-			$GLOBALS['table_prefix'] = 'wptests_';
-		}
-		if ( ! isset( $GLOBALS['wpdb'] ) ) {
-			$GLOBALS['wpdb']                  = new stdClass();
-			$GLOBALS['wpdb']->suppress_errors = false;
-			$GLOBALS['wpdb']->show_errors     = true;
-		}
-		return;
-	}
+	/** @var PDO */
+	private $sqlite;
 
 	/**
 	 *  Before each test, we create a new volatile database and WordPress tables.
@@ -47,10 +25,8 @@ public function setUp(): void {
 
 		$this->sqlite = new PDO( 'sqlite::memory:' );
 		$this->engine = new WP_SQLite_Driver(
-			array(
-				'connection' => $this->sqlite,
-				'database'   => 'wp',
-			)
+			new WP_SQLite_Connection( array( 'pdo' => $this->sqlite ) ),
+			'wp'
 		);
 
 		$translator = $this->engine;
@@ -462,7 +438,7 @@ public function testRecoverSerialized() {
 		);
 		$option_name          = 'serialized_option';
 		$option_value         = serialize( $obj );
-		$option_value_escaped = $this->engine->get_pdo()->quote( $option_value );
+		$option_value_escaped = $this->engine->get_connection()->quote( $option_value );
 		/* Note well: this is heredoc not nowdoc */
 		$insert = <<<QUERY
 		INSERT INTO `wp_options` (`option_name`, `option_value`, `autoload`)
@@ -488,7 +464,7 @@ public function testRecoverSerialized() {
 		++$obj ['two'];
 		$obj ['pi']          *= 2;
 		$option_value         = serialize( $obj );
-		$option_value_escaped = $this->engine->get_pdo()->quote( $option_value );
+		$option_value_escaped = $this->engine->get_connection()->quote( $option_value );
 		/* Note well: this is heredoc not nowdoc */
 		$insert = <<<QUERY
 		INSERT INTO `wp_options` (`option_name`, `option_value`, `autoload`)

tests/WP_SQLite_Driver_Tests.php

@@ -1,46 +1,21 @@
 <?php
 
-require_once __DIR__ . '/WP_SQLite_Translator_Tests.php';
-require_once __DIR__ . '/../wp-includes/sqlite-ast/class-wp-sqlite-driver.php';
-require_once __DIR__ . '/../wp-includes/sqlite-ast/class-wp-sqlite-driver-exception.php';
-require_once __DIR__ . '/../wp-includes/sqlite-ast/class-wp-sqlite-information-schema-builder.php';
-
 use PHPUnit\Framework\TestCase;
 
 class WP_SQLite_Driver_Tests extends TestCase {
-
+	/** @var WP_SQLite_Driver */
 	private $engine;
-	private $sqlite;
 
-	public static function setUpBeforeClass(): void {
-		// if ( ! defined( 'PDO_DEBUG' )) {
-		// define( 'PDO_DEBUG', true );
-		// }
-		if ( ! defined( 'FQDB' ) ) {
-			define( 'FQDB', ':memory:' );
-			define( 'FQDBDIR', __DIR__ . '/../testdb' );
-		}
-		error_reporting( E_ALL & ~E_DEPRECATED );
-		if ( ! isset( $GLOBALS['table_prefix'] ) ) {
-			$GLOBALS['table_prefix'] = 'wptests_';
-		}
-		if ( ! isset( $GLOBALS['wpdb'] ) ) {
-			$GLOBALS['wpdb']                  = new stdClass();
-			$GLOBALS['wpdb']->suppress_errors = false;
-			$GLOBALS['wpdb']->show_errors     = true;
-		}
-		return;
-	}
+	/** @var PDO */
+	private $sqlite;
 
 	// Before each test, we create a new database
 	public function setUp(): void {
 		$this->sqlite = new PDO( 'sqlite::memory:' );
 
 		$this->engine = new WP_SQLite_Driver(
-			array(
-				'connection' => $this->sqlite,
-				'database'   => 'wp',
-			)
+			new WP_SQLite_Connection( array( 'pdo' => $this->sqlite ) ),
+			'wp'
 		);
 		$this->engine->query(
 			"CREATE TABLE _options (
@@ -1234,14 +1209,14 @@ public function testColumnWithOnUpdate() {
 					'name'     => '_wp_sqlite__tmp_table_created_at_on_update',
 					'tbl_name' => '_tmp_table',
 					'rootpage' => '0',
-					'sql'      => "CREATE TRIGGER \"_wp_sqlite__tmp_table_created_at_on_update\"\n\t\t\tAFTER UPDATE ON \"_tmp_table\"\n\t\t\tFOR EACH ROW\n\t\t\tBEGIN\n\t\t\t  UPDATE \"_tmp_table\" SET \"created_at\" = CURRENT_TIMESTAMP WHERE rowid = NEW.rowid;\n\t\t\tEND",
+					'sql'      => "CREATE TRIGGER `_wp_sqlite__tmp_table_created_at_on_update`\n\t\t\t\tAFTER UPDATE ON `_tmp_table`\n\t\t\t\tFOR EACH ROW\n\t\t\t\tBEGIN\n\t\t\t\t  UPDATE `_tmp_table` SET `created_at` = CURRENT_TIMESTAMP WHERE rowid = NEW.rowid;\n\t\t\t\tEND",
 				),
 				(object) array(
 					'type'     => 'trigger',
 					'name'     => '_wp_sqlite__tmp_table_updated_at_on_update',
 					'tbl_name' => '_tmp_table',
 					'rootpage' => '0',
-					'sql'      => "CREATE TRIGGER \"_wp_sqlite__tmp_table_updated_at_on_update\"\n\t\t\tAFTER UPDATE ON \"_tmp_table\"\n\t\t\tFOR EACH ROW\n\t\t\tBEGIN\n\t\t\t  UPDATE \"_tmp_table\" SET \"updated_at\" = CURRENT_TIMESTAMP WHERE rowid = NEW.rowid;\n\t\t\tEND",
+					'sql'      => "CREATE TRIGGER `_wp_sqlite__tmp_table_updated_at_on_update`\n\t\t\t\tAFTER UPDATE ON `_tmp_table`\n\t\t\t\tFOR EACH ROW\n\t\t\t\tBEGIN\n\t\t\t\t  UPDATE `_tmp_table` SET `updated_at` = CURRENT_TIMESTAMP WHERE rowid = NEW.rowid;\n\t\t\t\tEND",
 				),
 			),
 			$results
@@ -4488,4 +4463,10 @@ public function testSessionSqlModes(): void {
 		$result = $this->assertQuery( 'SELECT @@session.SQL_mode' );
 		$this->assertSame( 'ONLY_FULL_GROUP_BY', $result[0]->{'@@session.SQL_mode'} );
 	}
+
+	public function testMultiQueryNotSupported(): void {
+		$this->expectException( WP_SQLite_Driver_Exception::class );
+		$this->expectExceptionMessage( 'Multi-query is not supported.' );
+		$this->assertQuery( 'SELECT 1; SELECT 2' );
+	}
 }