MongoDB Insert deprecation (updated to insertOne/insertMany)

[RobertoMachorro]

Added bindings and updated tests for insertOne/insertMany. Monk already supports bulkWrite.
This addresses issue #276 .

(node:30558) DeprecationWarning: collection.insert is deprecated. Use insertOne, insertMany or bulkWrite instead.

[codecov-io]

Codecov Report

Merging #280 into master will decrease coverage by 0.24%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
- Coverage   94.81%   94.57%   -0.25%     
==========================================
  Files           6        6              
  Lines         386      387       +1     
==========================================
  Hits          366      366              
- Misses         20       21       +1

Impacted Files	Coverage Δ
lib/collection.js	94.31% <100%> (+0.02%)	⬆️
lib/manager.js	94.73% <0%> (-0.76%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd1db07...109bcc0. Read the comment docs.

[faradaytrs]

Could you please do the same for count()

[mathieudutour]

How about updating the insert method to either use insertOne or insertMany` depending on whether an array is passed instead of adding 2 new methods?

[RobertoMachorro]

Could you please do the same for count()

@faradaytrs most probably will, also group is going to be deprecated in favor of aggregation, i saw some of the tests spitting that out

[RobertoMachorro]

How about updating the insert method to either use insertOne or insertMany` depending on whether an array is passed instead of adding 2 new methods?

@mathieudutour that's a great idea! Will do that for backwards compatibility, however, will still keep insertOne/Many because of upwards compatibility with MongoDB itself. The final say in all this - of course - is the Monk maintainers.

[osban]

@RobertoMachorro apparently the fields option is also deprecated, so if you could fix that too, that'd be great 🙂

[RobertoMachorro]

@RobertoMachorro apparently the fields option is also deprecated, so if you could fix that too, that'd be great 🙂

@osban will do, but didn't see the warning? could you post more info about it?

[osban]

@RobertoMachorro here's the warning message: (node:5151) DeprecationWarning: collection.find option [fields] is deprecated and will be removed in a later version.. It's when you only want the query to return certain fields. Do you need more info?

[RobertoMachorro]

@RobertoMachorro here's the warning message: (node:5151) DeprecationWarning: collection.find option [fields] is deprecated and will be removed in a later version.. It's when you only want the query to return certain fields. Do you need more info?

That works, thanks - just needed some context.

[mathieudutour]

let's even remove the other 2 methods, they are superfluous

[RobertoMachorro]

let's even remove the other 2 methods, they are superfluous

@mathieudutour that makes sense, i'll remove the insertOne/inserMany calls. Some of the mongodb-cli intuitiveness will be out, though.

[mathieudutour]

I'd say a single insert is a more intuitive than 2 different calls? The API surface is smaller -> easier to remember

[RobertoMachorro]

@mathieudutour i'm making sure to match your code style, but I don't see a ternary operator anywhere on the source, do you prefer not to use them and go with regular if blocks?

[mathieudutour]

I do use ternaries, but maybe I’d write const colcall = arrayInsert ? args.col.insertMany : args.col.insertOne (eg. remove the unnecessary parentheses and add a space)

Or

const colcall = arrayInsert
  ? args.col.insertMany
  : args.col.insertOne

On multiple lines

It might be worth adding prettier to not have to care about it hahaha

[RobertoMachorro]

I do use ternaries, but maybe I’d write const colcall = arrayInsert ? args.col.insertMany : args.col.insertOne (eg. remove the unnecessary parentheses and add a space)

I had it like that originally (not including the parameters in the ternary), however, Node doesn't like it. I've seen that happen with functions that return a promise as opposed to a value:

stack: >
  Collection.insertMany
  (/Projects/monk/node_modules/mongodb/lib/collection.js:504:32)

  insert (/Projects/monk/lib/collection.js:322:12)

  /Projects/monk/node_modules/monk-middleware-wait-for-connection/index.js:8:16
at:
  line: 504
  column: 32
  file: /Projects/monk/node_modules/mongodb/lib/collection.js
  function: Collection.insertMany
type: TypeError
tapCaught: returnedPromiseRejection
test: collection find limit/skip data
source: |2

    return executeOperation(this.s.topology, insertManyOperation, callback);
  -------------------------------^
  };
...

[RobertoMachorro]

Thanks to all that can test, I'll start a count and find/fields update on a separate branch.