Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default to using useUnifiedTopology option #277

Merged
merged 3 commits into from
Sep 24, 2019

Conversation

bobmoff
Copy link
Contributor

@bobmoff bobmoff commented Aug 20, 2019

@bobmoff bobmoff closed this Aug 21, 2019
@bobmoff bobmoff reopened this Aug 21, 2019
@mpangrazzi
Copy link
Contributor

can you add one or more tests as for useNewUrlParser option?

@codecov-io
Copy link

codecov-io commented Sep 5, 2019

Codecov Report

Merging #277 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
+ Coverage   94.81%   94.84%   +0.02%     
==========================================
  Files           6        6              
  Lines         386      388       +2     
==========================================
+ Hits          366      368       +2     
  Misses         20       20
Impacted Files Coverage Δ
lib/manager.js 95.55% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd1db07...1562e8c. Read the comment docs.

@bobmoff
Copy link
Contributor Author

bobmoff commented Sep 5, 2019

can you add one or more tests as for useNewUrlParser option?

done!

@mathieudutour
Copy link
Collaborator

Hum that's a breaking change, isn't it?
What's the reason to default to true?

@bobmoff
Copy link
Contributor Author

bobmoff commented Sep 6, 2019

DeprecationWarning: current Server Discovery and Monitoring engine is deprecated, and will be removed in a future version. To use the new Server Discover and Monitoring engine, pass option { useUnifiedTopology: true } to MongoClient.connect.

@mpangrazzi
Copy link
Contributor

@mathieudutour IMHO it seems to be very similar to useNewUrlParser option. It's due to an internal change in mongodb module, and it's not listed as a breaking change in their docs.

@mathieudutour mathieudutour merged commit ec30459 into Automattic:master Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants