Skip to content

Conversation

vianasw
Copy link
Contributor

@vianasw vianasw commented Oct 15, 2025

When we render a form submission that has a terms consent block, we're not stripping the period at the end of the label text, resulting in a period followed by a semicolon, like in this image:
Screenshot 2025-10-15 at 15 25 58

Fixes FORMS-324

Proposed changes:

  • Strip period from the label text before rendering on the form submission page.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Create a form and add a terms consent block.
  • Publish the post and go to submit the form.
  • Check that the term consent text has no period before the colon.

The Terms consent block has a period in its label and when we render the
form submission we add a colon at the end which then renders as `.:`.
I'm trimming the period at the end before inserting the colon.`
Copy link
Contributor

github-actions bot commented Oct 15, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/form-consent-label-colon-issue branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/form-consent-label-colon-issue

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Feature] Contact Form [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress labels Oct 15, 2025
Copy link
Contributor

github-actions bot commented Oct 15, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: November 4, 2025
    • Code freeze: November 3, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Oct 15, 2025
Copy link

jp-launch-control bot commented Oct 15, 2025

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@vianasw vianasw changed the title Fix/form consent label colon issue Forms: Fix terms consent label colon issue Oct 16, 2025
@vianasw vianasw added [Status] Needs Review This PR is ready for review. [Type] Bug When a feature is broken and / or not performing as intended and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Oct 16, 2025
@vianasw vianasw marked this pull request as ready for review October 16, 2025 08:32
@vianasw vianasw added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] In Progress [Status] Needs Review This PR is ready for review. labels Oct 16, 2025
Fix it also in the frontend for the ajax success response case.
@vianasw vianasw merged commit c368dcb into trunk Oct 16, 2025
67 checks passed
@vianasw vianasw deleted the fix/form-consent-label-colon-issue branch October 16, 2025 16:38
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 16, 2025
@github-actions github-actions bot added this to the jetpack/15.2 milestone Oct 16, 2025
annacmc pushed a commit that referenced this pull request Oct 17, 2025
* Remove period from labels on submission

The Terms consent block has a period in its label and when we render the
form submission we add a colon at the end which then renders as `.:`.
I'm trimming the period at the end before inserting the colon.`

* changelog

* Fix Terms consent period colon issue frontend side

Fix it also in the frontend for the ajax success response case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Contact Form [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant