-
Notifications
You must be signed in to change notification settings - Fork 835
Forms: Fix terms consent label colon issue #45509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The Terms consent block has a period in its label and when we render the form submission we add a colon at the end which then renders as `.:`. I'm trimming the period at the end before inserting the colon.`
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
Fix it also in the frontend for the ajax success response case.
* Remove period from labels on submission The Terms consent block has a period in its label and when we render the form submission we add a colon at the end which then renders as `.:`. I'm trimming the period at the end before inserting the colon.` * changelog * Fix Terms consent period colon issue frontend side Fix it also in the frontend for the ajax success response case.
When we render a form submission that has a terms consent block, we're not stripping the period at the end of the label text, resulting in a period followed by a semicolon, like in this image:

Fixes FORMS-324
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: