Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/action button to be reusable #41361

Merged
merged 18 commits into from
Jan 29, 2025

Conversation

CodeyGuyDylan
Copy link
Contributor

Proposed changes:

  • Moves action functions used in the ActionButton component to the component itself to make the component more easily reused elsewhere

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

Not at the moment, it makes the tracks names dynamic, but this PR doesn't include any extra uses of it so for now it is the same

Testing instructions:

  1. Checkout this branch via the Jetpack Beta plugin or your local dev environment
  2. Go to My Jetpack
  3. Make sure the Action button still works as expected
  4. Find a CTA that says "Activate" and ensure the product is successfully activated
    NOTE: There is a bug that prevents async update of the product status, so it may look like at first that the product was not activated, but refresh to check to make sure that it is
  5. Ensure the Upgrade or Get Plan or Learn More statuses take you to the product interstitial
    image
  6. Disconnect your user account and site and ensure the Connect CTA's work correctly too

@CodeyGuyDylan CodeyGuyDylan changed the base branch from trunk to add/mj-red-bubble-notice-when-plugins-need-installed January 28, 2025 16:28
@CodeyGuyDylan CodeyGuyDylan changed the base branch from add/mj-red-bubble-notice-when-plugins-need-installed to trunk January 28, 2025 16:28
Copy link
Contributor

github-actions bot commented Jan 28, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/action-button-to-be-reusable branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/action-button-to-be-reusable
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Package] My Jetpack [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Tests] Includes Tests labels Jan 28, 2025
Copy link
Contributor

github-actions bot commented Jan 28, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Protect plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 28, 2025
@CodeyGuyDylan
Copy link
Contributor Author

FYI whomever reviews this, this has been rebased with this PR so that the product loading statuses are fixed. Will wait until that PR is merged to rebase this with trunk and merge

Copy link
Contributor

github-actions bot commented Jan 28, 2025

Code Coverage Summary

Coverage changed in 2 files.

File Coverage Δ% Δ Uncovered
projects/packages/my-jetpack/_inc/components/product-card/index.tsx 0/24 (0.00%) 0.00% -9 💚
projects/packages/my-jetpack/_inc/components/connected-product-card/index.tsx 0/11 (0.00%) 0.00% -13 💚

3 files are newly covered.

File Coverage
projects/packages/my-jetpack/_inc/components/action-button/index.tsx 0/93 (0.00%) 💔
projects/packages/my-jetpack/_inc/components/action-button/secondary-button.tsx 0/5 (0.00%) 💔
projects/packages/my-jetpack/_inc/components/action-button/types.ts 0/0 (—%) 🤷

Full summary · PHP report · JS report

@CodeyGuyDylan CodeyGuyDylan force-pushed the update/action-button-to-be-reusable branch from 79d4507 to 966deb2 Compare January 29, 2025 16:05
grzegorz-cp
grzegorz-cp previously approved these changes Jan 29, 2025
Copy link
Contributor

@grzegorz-cp grzegorz-cp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected and looks good.

grzegorz-cp
grzegorz-cp previously approved these changes Jan 29, 2025
Copy link
Contributor

@grzegorz-cp grzegorz-cp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@CodeyGuyDylan CodeyGuyDylan merged commit 0818fd2 into trunk Jan 29, 2025
78 checks passed
@CodeyGuyDylan CodeyGuyDylan deleted the update/action-button-to-be-reusable branch January 29, 2025 23:53
@github-actions github-actions bot removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 29, 2025
@jeherve jeherve added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] My Jetpack [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Tests] Includes Tests [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants