-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/action button to be reusable #41361
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Protect plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
FYI whomever reviews this, this has been rebased with this PR so that the product loading statuses are fixed. Will wait until that PR is merged to rebase this with trunk and merge |
Code Coverage SummaryCoverage changed in 2 files.
3 files are newly covered.
|
… fix $not_shown_products.
79d4507
to
966deb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected and looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Proposed changes:
ActionButton
component to the component itself to make the component more easily reused elsewhereOther information:
Jetpack product discussion
N/A
Does this pull request change what data or activity we track or use?
Not at the moment, it makes the tracks names dynamic, but this PR doesn't include any extra uses of it so for now it is the same
Testing instructions:
NOTE: There is a bug that prevents async update of the product status, so it may look like at first that the product was not activated, but refresh to check to make sure that it is
Upgrade
orGet Plan
orLearn More
statuses take you to the product interstitialConnect
CTA's work correctly too