feat(core): create new rule for detecting missing nouns #2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijah-potter
changed the title
hippietrail
reviewed
Sep 27, 2025
| impl Default for DeterminerWithoutNoun { | ||
| fn default() -> Self { | ||
| let expr = SequenceExpr::default() | ||
| .then(|tok: &Token, _: &[char]| tok.kind.is_determiner()) |
There was a problem hiding this comment.
You'll want to weed out determiners that are also pronouns, especially "this" and "that".
I can't remember if "my" etc. are marked as determiners. They should be and I think they are. If so a couple of those are also pronouns, I think "her" and "its" off the top of my head. .kind_is_but_is_not() might suffice to address this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces a new rule that detects missing nouns when they're implied by a determiner.
How Has This Been Tested?
Additional unit tests.
Checklist