Pronoun after preposition #1544
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automattic#1511 I tried three different ways. The blacklist works best but feels heavy-handed or like "overfitting" to the given tests? I kept the other two predicates commented out plus notes about the prepositions known to sometimes cause false positives with naïve pattern.
hippietrail
added
help wanted
…onoun-after-preposition
…onoun-after-preposition
…onoun-after-preposition
…onoun-after-preposition
…onoun-after-preposition
…onoun-after-preposition
…onoun-after-preposition
…onoun-after-preposition
…onoun-after-preposition
…onoun-after-preposition
…onoun-after-preposition
…onoun-after-preposition
…onoun-after-preposition
…onoun-after-preposition
…onoun-after-preposition
…onoun-after-preposition
…onoun-after-preposition
…onoun-after-preposition
…onoun-after-preposition
…onoun-after-preposition
…trail/harper into pronoun-after-preposition
…onoun-after-preposition
…onoun-after-preposition
…onoun-after-preposition
…onoun-after-preposition
…onoun-after-preposition
…onoun-after-preposition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
#1511
Description
Attempt at implementing #1511
But it turns out there are many ways that a subject case pronoun can follow a preposition.
I tried to filter these out by calling
.is_likely_homograph()and by checking which other POSes the preposition has.But I passed more tests with a simple blacklist.
I left the other two approaches in the code along with a partial investigation of all POSes for all the known problematic prepositions.
In any case even though the sentences selected for unit tests pass, there are still many false positives in the snapshots for Alice in Wonderland and The Great Gatsby.
How Has This Been Tested?
I added unit tests from the issue and from the novels in our snapshot tests, but this is not sufficient.
Checklist