Calendar caching issues: Refresh PR 548 from Cojennin for issue 505. #754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cut a new release from develop
Old out of date PR: Automattic#548 This adapts the core elements while integrating changes made to calendar.php since the patch was created. The important thing it does is shift what we cache in `generate_post_li_html()` from being the final HTML to being the "information fields". This avoids having user-specific nonces get cached, allowing us to have the cache function without the user IDs, and thus allowing us to correctly purge the cache. The issues with these changes is that they don't move the needle. On my local site, the old caching brought generation time from 3s to 1s. With this caching, there's no noticeable difference at all, on or off the results were between 3.09 and 3.11 seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old out of date PR:
#548
Issue this addresses:
#505
This adapts the core elements of Cojennin's PR while integrating changes made to calendar.php since the patch was created.
The important thing it does is shift what we cache in
generate_post_li_html()from being the final HTML to being the "information fields". This avoids having user-specific nonces get cached, allowing us to have the cache function without the user IDs, and thus allowing us to correctly purge the cache.The issues with these changes is that they don't move the needle in terms of performance. On my local site, the old caching brought generation time from 3s to 1s. With this caching, there's no noticeable difference at all, on or off the results were between 3.09 and 3.11 seconds.