Fix Color Pop-In Bug #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of one at a time
justinmc
commented
Nov 3, 2016
| ) | ||
|
|
||
| # Returns new styles after updating the given atoms with the given color | ||
| def get_styles_for_color(self, color, atoms, styles): |
There was a problem hiding this comment.
This instance method doesn't use self. Is that usually ok in Python? Should I make it a class method, or move it to some other file outside of a class altogether?
There was a problem hiding this comment.
Yeah, this is fine; it's a actually a staticmethod (in python, a classmethod is one that gets the class as the first argument). So you can write this as
@staticmethod
def get_styles_for_color(color, atoms, styles):There was a problem hiding this comment.
Ok got it, I'll make this change really quick because it bothered me.
|
@avirshup Needs review please! |
|
👍 fix confirmed, code looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue: #39