Skip to content

OGSMOD-8139: Improve Test Framework Sync #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sebastienberube-adsk wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

OGSMOD-8139: Improve Test Framework Sync #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e61b4c8
Test without glFinish()
sebastienberube-adsk Oct 10, 2025
265c78e
Temp logging for CI
sebastienberube-adsk Oct 10, 2025
c67b50b
Test adding glFinish at the beginning of the 1st frame pass
sebastienberube-adsk Oct 10, 2025
7ae88c5
Try calling glFinish() just after endGL()
sebastienberube-adsk Oct 10, 2025
588f0d2
Remove temporary debug code.
sebastienberube-adsk Oct 24, 2025
ecc0fa1
Merge remote-tracking branch 'origin/main' into berubes/ogsmod-8139/i…
sebastienberube-adsk Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion test/RenderingFramework/OpenGLTestContext.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,11 @@ void OpenGLRendererContext::run(
{
_context->beginGL();
}
~Guard() { _context->endGL(); }
~Guard()
{
_context->endGL();
glFinish();
}
OpenGLRendererContext* _context { nullptr };
} guard(this);

Expand Down
15 changes: 0 additions & 15 deletions test/tests/testFramePasses.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,9 +482,6 @@ TEST(TestViewportToolbox, TestFramePasses_MultiViewports)

// Renders the frame pass.
framePass1.sceneFramePass->Render();

// Force GPU sync
context->_backend->waitForGPUIdle();
}

// Gets the input AOV's from the first frame pass and use them in all overlays so the
Expand Down Expand Up @@ -616,9 +613,6 @@ TEST(TestViewportToolbox, TestFramePasses_MultiViewportsClearDepth)

// Renders the frame pass.
framePass1.sceneFramePass->Render();

// Force GPU sync
context->_backend->waitForGPUIdle();
}

// Gets the 'depth' input AOV from the first frame pass and use it in all overlays so the
Expand Down Expand Up @@ -752,9 +746,6 @@ TEST(TestViewportToolbox, TestFramePasses_TestDynamicAovInputs)

// Renders the frame pass.
framePass1.sceneFramePass->Render();

// Force GPU sync
context->_backend->waitForGPUIdle();
}

HdRenderBuffer* colorBuffer =
Expand Down Expand Up @@ -899,9 +890,6 @@ TEST(TestViewportToolbox, TestFramePasses_ClearDepthBuffer)

// Renders the frame pass.
framePass1.sceneFramePass->Render();

// Force GPU sync
context->_backend->waitForGPUIdle();
}

// Gets the 'depth' input AOV from the first frame pass and use it in all overlays so the
Expand Down Expand Up @@ -1039,9 +1027,6 @@ TEST(TestViewportToolbox, TestFramePasses_ClearColorBuffer)

// Renders the frame pass.
framePass1.sceneFramePass->Render();

// Force GPU sync
context->_backend->waitForGPUIdle();
}

// Gets the 'color' input AOV from the first frame pass and use it in all overlays so the
Expand Down