Pass HdRendererCreateArgs in HdRenderSettingsMap with the desired Hgi #118
+7
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DDoS
force-pushed
the
sapona/update-render-settings-map
branch
5 times, most recently
from
a24d055 to
c809dad
Compare
DDoS
force-pushed
the
sapona/update-render-settings-map
branch
from
c809dad to
965218f
Compare
|
hodoulp
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CreateRenderDelegate()needs to know theHgiin use, otherwise it can't correctly callIsSupported()internally. It uses the default Hgi and that may fail.HGI_ENABLE_*environment variables if applicable, such asHGI_ENABLE_VULKAN.