Skip to content

Check restriction status only on cache #2358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Check restriction status only on cache #2358

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
25f7e13
Check inventory authentication status only on cache
Jun 18, 2021
a8ebe70
Only leave inventory untouched if registration is not enforced
Jun 19, 2021
f52e6a1
Allow unregistered players in not enforced config to use tab
Jun 19, 2021
c04a72b
Allow unregistered players in not enforced config to use tab
Jun 19, 2021
b1a9abc
Perform all restriction checks only on cache
Jun 19, 2021
e437321
Code clean up
Jun 19, 2021
cc2128b
Protect unknown data too
Jun 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/main/java/fr/xephi/authme/listener/protocollib/InventoryPacketAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,20 @@ public void register(BukkitService bukkitService) {
}

private boolean shouldHideInventory(String playerName) {
return !playerCache.isAuthenticated(playerName) && dataSource.isAuthAvailable(playerName);
if (playerCache.isAuthenticated(playerName)) {
// fully logged in - no need to protect it
return false;
}

if (dataSource.isCached()) {
// load from cache or only request once
return dataSource.isAuthAvailable(playerName);
}

// data source is not cached - this means queries would run blocking
// Assume the player is registered would mean the inventory will be protected
// and any potential information leak can be prevented
return true;
}

public void unregister() {
Expand Down