Skip to content

Conversation

@QuickGlare
Copy link

No description provided.

@sgdc3
Copy link
Member

sgdc3 commented Oct 16, 2019

@QuickGlare lol i missed this notification

@sgdc3 sgdc3 requested review from ljacqu and sgdc3 October 16, 2019 15:42
@sgdc3
Copy link
Member

sgdc3 commented Oct 16, 2019

why not using regex directly at this point?

@ljacqu
Copy link
Member

ljacqu commented Oct 16, 2019

Oh, I was on vacation when this came in and I wanted to comment on it: I'm thinking a combination of Pattern#escape and just having * function as wildcard would be sufficient, no? I think that would have low potential for errors or unexpected behavior and it's easy to explain that * = wildcard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants