Skip to content

Remove mxcube sample name validation #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fhernandezvivanco merged 1 commit into from
Mar 19, 2026
Merged

Remove mxcube sample name validation #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions mxcubeweb/core/components/lims.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
import json
import logging
import math
import re
import sys
from http import HTTPStatus
from time import sleep
Expand All @@ -17,9 +16,6 @@
from mxcubecore.model.lims_session import LimsSessionManager

from mxcubeweb.core.components.component_base import ComponentBase
from mxcubeweb.core.util import fsutils

VALID_SAMPLE_NAME_REGEXP = re.compile("^[a-zA-Z0-9:+_-]+$")


class Lims(ComponentBase):
Expand Down Expand Up @@ -359,12 +355,6 @@ def synch_with_lims(self, lims_name):
if not isinstance(sample_name, str) or not sample_name:
continue

if not VALID_SAMPLE_NAME_REGEXP.match(sample_name):
raise AttributeError(
"sample name for sample %s contains an incorrect character"
% sample_info
)

try:
basket = int(sample_info["containerSampleChangerLocation"])
except (TypeError, ValueError, KeyError):
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "mxcubeweb"
version = "4.238.0.54"
version = "4.238.0.55"
license = "LGPL-3.0-or-later"
description = "MXCuBE Web user interface"
authors = ["The MXCuBE collaboration <mxcube@esrf.fr>"]
Expand Down
Loading