Skip to content

Swap order for 'disabled' default #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikssod merged 4 commits into from
Feb 20, 2026
Merged

Swap order for 'disabled' default #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
827b3b5
Swap order for 'disabled' default
Feb 19, 2026
6c39714
Update actual defaults
Feb 19, 2026
ec80e11
Fix pre-commit
Feb 19, 2026
0c47322
Fix pre-commit
Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions mxcubecore/HardwareObjects/ANSTO/prefect_flows/config/default_params_pins.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,13 @@ screening:
resolution: 2.0 # Ångström (16M)
transmission: 0.5 # Percentage


grid_scan:
md3_alignment_y_speed: 1.0 # mm/s
omega_range: 0.0 # Degrees
photon_energy: 13.0 # keV
resolution: 1.5 # Ångström (16M)
transmission: 1.0 # Percentage
detector_roi_mode: "4M" # 4M or disabled
detector_roi_mode: "disabled" # 4M or disabled
grid_step: "20x20"

one_shot:
Expand Down
2 changes: 1 addition & 1 deletion mxcubecore/HardwareObjects/ANSTO/prefect_flows/config/default_params_trays.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ grid_scan:
photon_energy: 13.0 # keV
resolution: 1.5 # Ångström (16M)
transmission: 1.0 # Percentage
detector_roi_mode: "4M" # 4M or disabled
detector_roi_mode: "disabled" # 4M or disabled
# Only used for trays
auto_create_well: false
project_name: null
Expand Down
4 changes: 2 additions & 2 deletions mxcubecore/HardwareObjects/ANSTO/prefect_flows/schemas/dialog_boxes/grid_scan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ def get_grid_scan_schema(partial_udc: bool = False) -> dict:
"widget": "textarea",
},
"detector_roi_mode": {
"title": "Detector ROI Mode",
"title": "Detector 4M Mode",
"type": "string",
"enum": ["4M", "disabled"],
"enum": ["disabled", "4M"],
"default": str(
get_dialog_box_param("detector_roi_mode", collection_type="grid_scan")
),
Expand Down
Loading