Skip to content

feat: Update single prediction samplesheet to use job name as meta.id & update jobs list status badges (SBP-424)#98

Merged
vtnphan merged 10 commits into
mainfrom
sbp-424
Jul 9, 2026
Merged

feat: Update single prediction samplesheet to use job name as meta.id & update jobs list status badges (SBP-424)#98
vtnphan merged 10 commits into
mainfrom
sbp-424

Conversation

@minh-biocommons

@minh-biocommons minh-biocommons commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Pull Request

Summary

SBP-424: Update single prediction samplesheet to use job name as meta.id

Bulk of the PR are just tests missing from existing pages & components

Changes

  • Update single prediction samplesheet to use job name as meta.id
  • Made status badges on jobs list consistent
  • Use consistent reactive forms accross 4 workflow pages
  • Added tests for de novo design & related components
  • Made single prediction sequence textarea input size consistent with other fields on the form
  • Minor: removed ending dots from input error validation messages

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added or updated documentation where necessary
  • I have run linting and unit tests locally
  • The code follows the project's style guidelines

Screenshots

image image

@minh-biocommons minh-biocommons requested a review from vtnphan July 7, 2026 04:46
@minh-biocommons minh-biocommons changed the title refactor: update job status display and improve samplesheet ID handling feat: Update single prediction samplesheet to use job name as meta.id, update jobs list status badges (SBP-424) Jul 8, 2026
@minh-biocommons minh-biocommons changed the title feat: Update single prediction samplesheet to use job name as meta.id, update jobs list status badges (SBP-424) feat: Update single prediction samplesheet to use job name as meta.id & update jobs list status badges (SBP-424) Jul 8, 2026
@vtnphan vtnphan merged commit d82ba4f into main Jul 9, 2026
8 checks passed
@amandazhuyilan amandazhuyilan deleted the sbp-424 branch July 9, 2026 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants