feat: single prediction sequence name for fasta#97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
SBP-458 — Replaces auto-generated FASTA header IDs (e.g.
pro_1) with a required, user-editable sequence name, tags each header with its molecule type (e.g.>seq1|protein), and adds a character-position ruler above the sequence input.Changes
namefield per entity row, validated (non-empty, no spaces/underscores, unique) viavalidateFastaHeader.|type(ligand →smiles); removed the oldgetFastaSequenceIdgenerator.idnow uses the row name instead ofentity_N.getSequenceCells) behind a transparent, fully-editable textarea so native typing/selection/paste/scroll behaviour is preserved; scroll position is kept in sync viasyncSequenceOverlayScroll.pro_1/entity_NIDs need to account for user-supplied names and the|typesuffix.How to Test
>name input; blank/spaced/underscored or duplicate names show a validation error.>name_1|protein.|smiles/|ccd.npm testandnpm run prettier:checkpass.Type of change
Checklist