Skip to content

fix: use internal run ids for job/result endpoints (SBP-421)#97

Merged
marius-mather merged 11 commits into
mainfrom
fix/job-api-ids
Jul 10, 2026
Merged

fix: use internal run ids for job/result endpoints (SBP-421)#97
marius-mather merged 11 commits into
mainfrom
fix/job-api-ids

Conversation

@marius-mather

@marius-mather marius-mather commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Pull Request

Summary

SBP-421: now that we've implemented job queueing, workflow runs don't have a seqera ID initially. This PR changes all the job-related endpoints to expect and use the internal workflow run ID for lookups.

The backend is already providing the internal ID to the frontend for the job list, so we don't need frontend changes for this.

Changes

  • Make clear when we are using WorkflowRun.id vs. WorkflowRun.seqera_run_id for lookups
  • Use internal id as the initial ID for all workflow run endpoints
  • Update delete/cancel endpoints to deal with queued/pending jobs, in addition to Seqera workflows

How to Test

Run uv run pytest

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added or updated documentation where necessary
  • I have run linting and unit tests locally
  • The code follows the project's style guidelines

@vtnphan vtnphan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for a quick fix! Also tested locally, good to go!

@marius-mather marius-mather merged commit 4b7b17b into main Jul 10, 2026
2 checks passed
@amandazhuyilan amandazhuyilan deleted the fix/job-api-ids branch July 13, 2026 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants